From owner-cvs-src@FreeBSD.ORG Tue Jul 22 05:52:45 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D401937B401; Tue, 22 Jul 2003 05:52:45 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E43543FD7; Tue, 22 Jul 2003 05:52:38 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6MCqX0U043871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2003 15:52:33 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6MCqSWL043864; Tue, 22 Jul 2003 15:52:28 +0300 (EEST) (envelope-from ru) Date: Tue, 22 Jul 2003 15:52:28 +0300 From: Ruslan Ermilov To: Gregory Neil Shapiro Message-ID: <20030722125228.GC36151@sunbay.com> References: <200307100453.h6A4rXeH084564@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pY3vCvL1qV+PayAL" Content-Disposition: inline In-Reply-To: <200307100453.h6A4rXeH084564@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/sendmail Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 12:52:46 -0000 --pY3vCvL1qV+PayAL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 09, 2003 at 09:53:32PM -0700, Gregory Neil Shapiro wrote: > gshapiro 2003/07/09 21:53:32 PDT >=20 > FreeBSD src repository >=20 > Modified files: > etc/sendmail Makefile=20 > Log: > Continue trying to build SENDMAIL_CF if the user uses SENDMAIL_CF > instead of SENDMAIL_MC but don't remove on it 'make clean' as the > user may not have the original .mc file and removing it could be > dangerous (e.g., make SENDMAIL_CF=3D/etc/mail/sendmail.cf clean). > =20 > Noticed by: peter > MFC after: 3 days > =20 > Revision Changes Path > 1.26 +5 -2 src/etc/sendmail/Makefile >=20 Gregory, I have trouble understanding what this commit fixes. I have read the preceding discussion where you explained to Peter that SENDMAIL_CF should have a /full/path/to/sendmail.cf, but even after that it's still unclear: just reverting to rev. 1.24 of etc/sendmail/Makefile gives the below, which looks very consistent to me: : Script started on Tue Jul 22 15:46:47 2003 : # ident Makefile : Makefile: : $FreeBSD: src/etc/sendmail/Makefile,v 1.24 2003/07/06 18:54:18 gshap= iro Exp $ : # ls -l /etc/mail/sendmail.cf : -r--r--r-- 1 root wheel 57028 Jul 22 15:02 /etc/mail/sendmail.cf : # make -n clean SENDMAIL_CF=3D/etc/mail/sendmail.cf : rm -f freebsd.cf =20 No attempts to remove /etc/mail/sendmail.cf. : # make -n install SENDMAIL_CF=3D/etc/mail/sendmail.cf No attempts to install the file over itself. : # make -n install SENDMAIL_CF=3D/foo/bar/sendmail.cf : install -o root -g wheel -m 644 /foo/bar/sendmail.cf /etc/mail/sendmail.= cf : # make -n clean SENDMAIL_CF=3D/foo/bar/sendmail.cf : rm -f freebsd.cf =20 No attempts to remove /foo/bar/sendmail.cf, either. : Script done on Tue Jul 22 15:47:47 2003 We weren't removing the ${SENDMAIL_CF} file because we weren't adding it to the list of files to build (${ALL}) which we then remove (CLEANFILES=3D${ALL}). Can you please clarify this? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --pY3vCvL1qV+PayAL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/HTOMUkv4P6juNwoRAhutAJ40MpeaAGTSOKV7qKoqQlhGPAL4hwCcDwCZ sl9ca6lnbmCeSXkXg+dYm6g= =OKcK -----END PGP SIGNATURE----- --pY3vCvL1qV+PayAL--