From owner-cvs-src Mon Feb 10 11:44:10 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 586EF37B401; Mon, 10 Feb 2003 11:44:06 -0800 (PST) Received: from relay1.cris.net (relay1.cris.net [212.110.128.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19E9B43FA3; Mon, 10 Feb 2003 11:44:03 -0800 (PST) (envelope-from phantom@phantom.cris.net) Received: from phantom.cris.net (root@phantom.cris.net [212.110.130.74]) by relay1.cris.net (8.12.6/8.12.6) with ESMTP id h1ALnKvb069980; Mon, 10 Feb 2003 21:49:21 GMT Received: (from phantom@localhost) by phantom.cris.net (8.12.6/8.12.2) id h1AJoWDJ028591; Mon, 10 Feb 2003 21:50:32 +0200 (EET) (envelope-from phantom) Date: Mon, 10 Feb 2003 21:50:31 +0200 From: Alexey Zelkin To: Alfred Perlstein Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, legacy-committers@FreeBSD.org Subject: Re: cvs commit: src/include pthread.h src/lib/libc_r/uthread uthread_attr_getstack.c uthread_attr_setstack.c src/lib/libpthread/thread thr_attr_getstack.c thr_attr_setstack.c src/lib/libc_r/man pthread_attr.3 Message-ID: <20030210215031.A28553@phantom.cris.net> References: <200302100848.h1A8m4Fj054987@repoman.freebsd.org> <20030210120147.A25796@phantom.cris.net> <20030210105459.GU88781@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20030210105459.GU88781@elvis.mu.org>; from alfred@FreeBSD.org on Mon, Feb 10, 2003 at 02:54:59AM -0800 X-Operating-System: FreeBSD 4.7-STABLE i386 Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, On Mon, Feb 10, 2003 at 02:54:59AM -0800, Alfred Perlstein wrote: > > On Mon, Feb 10, 2003 at 12:48:04AM -0800, Alfred Perlstein wrote: > > > Log: > > > Add pthread_attr_getstack() and pthread_attr_setstack(). > > * Alexey Zelkin [030210 01:55] wrote: > > hi, > > > > Who reviewed this change ? Did you told to Dan before doing it ? > > I thought it was fine, I've done work on the pthreads library before. Dan is owning some uncommitted patches used to convert libc_r to using *context() stuff, instead of longjmp()'s. Making uncoordinated changes just may create unneeded problems, IMO. > > And last, that purpose of this functionality ? (I have seen a diff, > > but it's interesting how these functions are supposed to be used?) > > This is to bring us a function that is required by: > http://www.opengroup.org/onlinepubs/007904975/functions/pthread_attr_getstack.html Hmm.. Reading of -committers before morning coffee isn't good idea. Sorry Alfred. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message