From owner-freebsd-fs@FreeBSD.ORG Fri Jun 3 10:59:11 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64BEF106566B; Fri, 3 Jun 2011 10:59:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id D233F8FC16; Fri, 3 Jun 2011 10:59:10 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p53Ax4L9081274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 3 Jun 2011 13:59:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p53Ax4PY012698; Fri, 3 Jun 2011 13:59:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p53Ax4Nl012697; Fri, 3 Jun 2011 13:59:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 3 Jun 2011 13:59:04 +0300 From: Kostik Belousov To: Bruce Evans Message-ID: <20110603105904.GM48734@deviant.kiev.zoral.com.ua> References: <1307069726.2024.18.camel@nsl> <1307071973.2024.19.camel@nsl> <20110603173555.X994@besplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p/yOlLEfnp/ZBhGR" Content-Disposition: inline In-Reply-To: <20110603173555.X994@besplex.bde.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org, rmacklem@freebsd.org Subject: Re: [PATCH] Set the DE_UPDATE flag on the directory node on msdosfs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 10:59:11 -0000 --p/yOlLEfnp/ZBhGR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 03, 2011 at 06:25:07PM +1000, Bruce Evans wrote: > On Fri, 3 Jun 2011, Kevin Lo wrote: >=20 > >Kevin Lo wrote: > >>If you try to NFS export a fat32 formatted external usb devices, > >>you'll notice if a new file is created, you won't see that file > >>on the NFS client. The reason is msdosfs(5) doesn't change the > >>modify time of the directory when an entry is created. > >> > >>Attached is a patch against HEAD that sets DE_UPDATE on the > >>directory node in both createde() and removede(). > >>Please test it, thanks. >=20 > It breaks compatibility with MSDOS and Windows. >=20 > No correct fix is evident. ffs maintains the generation count va_filerev > which should help, but: > - ffs only increments it when a file mtime is updated. > - msdosfs doesn't properly maintain it (it initializes to a non-random > number related to the current time when the vnode is initialized, but > never increments it). > - the old nfs client doesn't use it > - the new nfs client does use it for v4. I don't know if this use is > sufficient (it has to get it from the server to work for this). It seems that reporter forgot to mention this, but the problem was reported for the _linux_ NFS client mounting FAT share from the FreeBSD server. --p/yOlLEfnp/ZBhGR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3ovncACgkQC3+MBN1Mb4h1uACdGiVfIoDaiIqC1giLotN5Tk3x xSUAoLNpnJEms05CTZceWpBd0Lj0799d =xFLr -----END PGP SIGNATURE----- --p/yOlLEfnp/ZBhGR--