From owner-freebsd-ipfw@FreeBSD.ORG  Thu Mar 31 17:11:19 2011
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ECE00106566B;
	Thu, 31 Mar 2011 17:11:19 +0000 (UTC) (envelope-from ae@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C56E58FC08;
	Thu, 31 Mar 2011 17:11:19 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2VHBJEi000304;
	Thu, 31 Mar 2011 17:11:19 GMT (envelope-from ae@freefall.freebsd.org)
Received: (from ae@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2VHBJ8n000300;
	Thu, 31 Mar 2011 17:11:19 GMT (envelope-from ae)
Date: Thu, 31 Mar 2011 17:11:19 GMT
Message-Id: <201103311711.p2VHBJ8n000300@freefall.freebsd.org>
To: boris@tagnet.ru, ae@FreeBSD.org, freebsd-ipfw@FreeBSD.org
From: ae@FreeBSD.org
Cc: 
Subject: Re: kern/152887: [ipfw] Can not set more then 1024 buckets with
	buckets flag
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2011 17:11:20 -0000

Synopsis: [ipfw] Can not set more then 1024 buckets with buckets flag

State-Changed-From-To: open->analyzed
State-Changed-By: ae
State-Changed-When: Thu Mar 31 16:51:11 UTC 2011
State-Changed-Why: 
There is a bug in ipdn_bound_var() function. It is designed
to bound variables between minimum and maximum values. But
it does not work as expected and user can set value bigger
than maximum allowed.

So, i can fix this function and you will not be able to
set 8k value for buckets. The hardcoded maximum for 
buckets is 1024. Are you agree with this change?


http://www.freebsd.org/cgi/query-pr.cgi?pr=152887