From nobody Mon Nov 17 17:54:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9FkD0nytz6Gfjr; Mon, 17 Nov 2025 17:54:28 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9FkC71jBz3lmV; Mon, 17 Nov 2025 17:54:27 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763402068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9HFZChMIOzU/Q7Tfyf1fFoaqxMFcsEJ6LxQ5LailWhA=; b=h6RZtc08XvfsOhkaWatL78YnKWUkJzJ6in9GeRr7my8hDFrMDtVFoA0kQyJ3ukFFgQvQo9 G4WDQ+lMFisRRu3liJK9zCEoKTyx9PCMJqsHFi85Mjh/XmA8jh6Wh36zsZmalhxeRm95s0 JCgxmaQ9Y6Fyv0cKIiLVb1Zhin895vIs9GSo1bkljTcORyIKImKpvC3ZgMKSnXOxmPxx4D cjuttk+MkIsjJ2GEEkMo+8rF9XCuvQFe6oooyBxbXyVdgsv+XJknAuUf78FH22CKVMIoQ5 vyyJttCwNLw7ccaKirp0NGxqfyk8vg0q2hpwbGlcRQHJQNM9pCqw5UUBRmO4vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763402068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9HFZChMIOzU/Q7Tfyf1fFoaqxMFcsEJ6LxQ5LailWhA=; b=FoMf/YV4qIje1Vf208mLGYRHmPA0X+UFJFNi+WFde+VAdmIuYxQlf0Tlw+vr8x72ICgALc sjL2zVYMmuEEj6w8EzXz82H7+/BarNAwipJdqfG39EgAlHAvioH3j8QQ1DlBBo40HArAf9 lbj899WzNUD/U26q+zTmFRY/bvsz0vP9bT3blfRB76zt0P+wxv1GUvpyLtXPQ58Rl1duUV Ih30gpNeWHo5bUZDSbbkhNQAmv3qWUkJrouD3wXgocLZX5//PKaksUZcPz/UVv0IXArOvO Zr0hUS57aHHTSJsG8RAWh3eV74fmbxLmvqSdHRvvRa5mrIbIIR+39ARCxJNtMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763402068; a=rsa-sha256; cv=none; b=oTIL1lnEAu/HbiZ7LQp7vL4wZ3rOtE/wPkEC3zfXY+WNpu/Eeui36Zv/xRP+raDjZ0qa3w ABGH2P3TYvQxcLtn42eZQIzSplUV3Bayn+dJoJ5H8vC+dbWlJPSx0hdfv+WSNxklrtUPP1 uUVBJFrKSHDcnzYk+x5dUPKAnnIpa7gJDQQtBrE7dLUQIJTNx4NrUXcCY8RjvQw8oWwMJK l7JjPbUEImHwCSSnMNXA1Fme2WzPt9F/83RmQJ/B31ytiNQ2DfzHcBH2Gplqoln200oWGH 74kZ62GeWS3piYU7f96Trh5RaiCxKmm9bo2iStHSXybPFVoPwtgOZuoC452U/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2804:f1c:34:1001:8922:7658:64c:f767] (unknown [IPv6:2804:f1c:34:1001:8922:7658:64c:f767]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d9FkC0lhyzD8B; Mon, 17 Nov 2025 17:54:26 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: Date: Mon, 17 Nov 2025 14:54:26 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM To: Gleb Smirnoff Cc: "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202511110246.5AB2kdQc077401__35176.4420907543$1762829211$gmane$org@gitrepo.freebsd.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/11/25 18:41, Gleb Smirnoff wrote: > On Fri, Nov 14, 2025 at 06:03:15PM -0300, Renato Botelho wrote: > R> After upgrading my laptop this morning I noticed it was freezing after > R> suspend/resume. I've bisected and ended up on this commit. > R> > R> I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed by > R> f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue. > R> > R> My system is running today's CURRENT at 82d8a5029a80. > > Looks like the commit you point at can't be a culprit. Looking closer to your > description "reverting d6f10a5d013f followed by f1b9c1aafd84 and 3deb21f1afd5" > it seems that the only functional change is addition of device tpm and > rdrand_rng and option RANDOM_ENABLE_TPM to the GENERIC. > > Can you please try unmodified main sources at 82d8a5029a80, but modify GENERIC > to remove these two lines: > > +# random(4) > +device rdrand_rng # Intel Bull Mountain RNG > +device tpm # Trusted Platform Module > +options RANDOM_ENABLE_TPM # enable entropy from TPM 2.0 > > If that helps, can you please find which particular line makes the > regression. Hello Gleb! I was far from keyboard during the weekend but I tested it today and RANDOM_ENABLE_TPM is the option that trigger the issue. I've commented out RANDOM_ENABLE_{TPM,KBD,MOUSE} on unpatched src at 82d8a5029a80 and suspend/resume worked as expected. Uncommenting RANDOM_ENABLE_TPM made it to stop working again. -- Renato Botelho