Date: Fri, 13 Jan 2017 13:47:36 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Craig Rodrigues <rodrigc@crodrigues.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale Message-ID: <20170113124736.GA91713@stack.nl> In-Reply-To: <681075F8-78D1-43FF-A75D-71D5CDBA3AB4@gmail.com> References: <201508112159.t7BLxa6U057950@repo.freebsd.org> <CAG=rPVe%2B%2BFOHgrsYH4_hQeASFSaRA%2BqjbCddiPk1FiAqJE6_Bg@mail.gmail.com> <681075F8-78D1-43FF-A75D-71D5CDBA3AB4@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 11, 2017 at 02:14:13AM -0800, Ngie Cooper (yaneurabeya) wrote: > > On Aug 11, 2015, at 6:45 PM, Craig Rodrigues <rodrigc@crodrigues.org> wrote: > > > > On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker <jilles@freebsd.org <mailto:jilles@freebsd.org>> wrote: > > Author: jilles > > Date: Tue Aug 11 21:59:36 2015 > > New Revision: 286649 > > URL: https://svnweb.freebsd.org/changeset/base/286649 <https://svnweb.freebsd.org/changeset/base/286649>; > > Log: > > Fix and re-enable UTF-8 tests. > > Modified: > > head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c > > head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c > > head/lib/libc/tests/locale/Makefile > > Thanks for fixing this. What is the procedure that FreeBSD > > developers need to follow to push this kind of change upstream to > > NetBSD? > I’m submitting PRs with NetBSD as needed. To be frank, I’m not > sure that this change is needed upstream (I’m probably going to #ifdef > the code — some things I found when trying to push things back). I think the change is required upstream as well, since UTF-8 no longer includes code points greater than 0x10ffff per RFC 3629 (this change made the code point ranges of UTF-8 and UTF-16 the same). The sequences that used to correspond to code points greater than 0x10ffff shall be treated as invalid. See also SVN r286490, r286491, r287125. I suppose I should have included this reasoning in the original commit message. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170113124736.GA91713>