Date: Thu, 10 Feb 2011 00:10:08 +0800 From: Sunpoet Hsieh <sunpoet@sunpoet.net> To: arrowdodger <6yearold@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. Message-ID: <20110209161008.GD87684@bonjour.sunpoet.net> In-Reply-To: <AANLkTimx%2B6ybx9ULw8a=bfMZJ0tC1MKcg_QzRKsTTvjU@mail.gmail.com> References: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> <AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek@mail.gmail.com> <AANLkTi=uPh6PJiBcNWyMRnWK9Wf18R9eY91%2Be1CXRTgQ@mail.gmail.com> <AANLkTikwEoU=O5%2BncTPEOZMaMGFfoDLC_Q%2Bnr_NbWiec@mail.gmail.com> <AANLkTimx%2B6ybx9ULw8a=bfMZJ0tC1MKcg_QzRKsTTvjU@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 09, 2011 at 06:24:34PM +0300, arrowdodger wrote:
> On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh <sunpoet@sunpoet.net> wrote:
>=20
> > It looks like you'll have two ports, version 1 and 2, and these two
> > ports do not conflict with each other.
> > IMHO, I would simply use devel/tortoisehg1 for version 1 and
> > devel/tortoisehg for upcoming version 2.
> > You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK=
or
> > Qt.
> >
> Okay.
>=20
> Now regarding this:
>=20
> > >> In your case, it can be done without extra patch files.
> > >>
> > >> .if !defined(WITH_NAUTILUS)
> > >> @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
> > >> .endif
> > >> .if !defined(WITH_NLS)
> > >> @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
> > >> .endif
> >
> -e 'x,y D' removes whole line, so all lines under removed line get shifte=
d.
> So, it's impossible to apply them in all combinations.
> I'm not familiar with sed, but is it possible to delete whole line, but
> leave \n at the end so line numbers will not be shifted?
You're right.
I'll use @${REINPLACE_CMD} -e '153,154 s|^|# |' ${WRKSRC}/${PYSETUP} instea=
d.
> PYDISTUTILS_EGGINFO defaults to
> >
> > ${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/=
[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
> > (Mk/bsd.python.mk, around line 509)
> >
> > For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_=
VER.
> > (Mk/bsd.python.mk, around line 372-410)
> >
> Okay, i will look there.
>=20
> By the way, currently 'make fetch' does not work, because hosting site ha=
ve
> broken certs. So, i was forced to do this:
> RUN_DEPENDS=3D hg:${PORTSDIR}/devel/mercurial \
> wget:${PORTSDIR}/ftp/wget
>=20
> FETCH_CMD=3Dwget
> FETCH_BEFORE_ARGS=3D--no-check-certificate
>=20
> Is it ok?
First, it should be FETCH_DEPENDS, not RUN_DEPENDS.
Back to the download problem, make fetch fails due to the default FETCH_ARG=
S (-AFpr).
-A flag denies "301/302 redirect" used by bitbucket.org to redirect request=
s to the destination.
It finally goes to cdn.bitbucket.org.
Therefore, you have two options:
1. Set MASTER_SITES=3Dhttp://cdn.bitbucket.org/tortoisehg/targz/downloads/ =
to skip redirection.
2. Set FETCH_ARGS=3D-Fpr to allow redirect.
I prefer 1.
Detailed logs shown as follows:
% make fetch
=3D> tortoisehg-1.1.9.1.tar.gz doesn't seem to exist in /usr/ports/distfile=
s/.
=3D> Attempting to fetch http://bitbucket.org/tortoisehg/targz/downloads//t=
ortoisehg-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:80
requesting http://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9=
=2E1.tar.gz
301 redirect to https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg=
-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:443
SSL connection established using DHE-RSA-AES256-SHA
Certificate subject: /C=3DNL/O=3Dbitbucket.org/OU=3DGT16385137/OU=3DSee www=
=2Egeotrust.com/resources/cps (c)09/OU=3DDomain Control Validated - QuickSS=
L(R)/CN=3Dbitbucket.org
Certificate issuer: /C=3DUS/O=3DEquifax/OU=3DEquifax Secure Certificate Aut=
hority
requesting https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.=
9.1.tar.gz
302 redirect to http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortois=
ehg-1.1.9.1.tar.gz
looking up cdn.bitbucket.org
connecting to cdn.bitbucket.org:80
requesting http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1=
=2E1.9.1.tar.gz
remote size / mtime: 6815613 / 1296700276
Best regards,
--=20
Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110209161008.GD87684>