Date: Sat, 17 Dec 2016 10:35:46 -0500 From: "Jason E. Hale" <jhale@freebsd.org> To: Raphael Kubo da Costa <rakuco@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r428683 - in head/security: pinentry pinentry-qt4 pinentry/files Message-ID: <CAJE75NEm0TOkFrgLPTXuMNPP8McgkkS9-uuzWoYXYWg6F9PHjQ@mail.gmail.com> In-Reply-To: <8660miveyx.fsf@FreeBSD.org> References: <201612161531.uBGFVOI4055900@repo.freebsd.org> <8660miveyx.fsf@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 17, 2016 at 8:53 AM, Raphael Kubo da Costa <rakuco@freebsd.org> wrote: > "Jason E. Hale" <jhale@FreeBSD.org> writes: > >> Author: jhale >> Date: Fri Dec 16 15:31:24 2016 >> New Revision: 428683 >> URL: https://svnweb.freebsd.org/changeset/ports/428683 >> >> Log: >> Update to 1.0.0 >> Add LICENSE (GPLv2+) >> Dependency cleanup >> Whitespace fix >> Remake patches >> Take maintainership > > This broke pinentry-qt5: > > checking for Qt5Core >= 5.0.0 Qt5Gui >= 5.0.0 Qt5Widgets >= 5.0.0... yes > checking for Qt5Core >= 5.7.0... no > checking for moc... /usr/local/lib/qt5/bin/moc > checking moc version... no > checking for moc-qt5... no > checking for qtchooser... no > ./configure: qtchooser: not found > checking for QtCore >= 4.6.0 QtGui >= 4.6.0... yes > checking for moc... (cached) /usr/local/lib/qt5/bin/moc > checking moc version... no > checking for moc-qt4... no > configure: error: No pinentry enabled. Hmm, I ran all the flavors through poudriere before the commit and never ran across this and I can't reproduce it. It looks like the configure script has the correct moc, but the moc version detection is failing. The version detection scheme is exactly the same in the qt.m4 file as the previous version, so why it's only not working with this version is beyond me. The only thing they changed in that file was requiring c++11 for Qt >= 5.7.0 which wouldn't apply here. AC_CHECK_TOOL(MOC, moc) AC_MSG_CHECKING([moc version]) mocversion=`$MOC -v 2>&1` mocversiongrep=`echo $mocversion | grep "Qt 5\|moc 5"` if test x"$mocversiongrep" != x"$mocversion"; then AC_MSG_RESULT([no]) $ /usr/local/lib/qt5/bin/moc -v moc 5.6.2 Which satisfies the condition, unless your 'moc -v' is barfing out something strange.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NEm0TOkFrgLPTXuMNPP8McgkkS9-uuzWoYXYWg6F9PHjQ>