From owner-svn-src-all@FreeBSD.ORG Sat Jun 13 14:48:58 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 39825E0F for ; Sat, 13 Jun 2015 14:48:58 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ig0-f181.google.com (mail-ig0-f181.google.com [209.85.213.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3B8C8D3 for ; Sat, 13 Jun 2015 14:48:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by igbpi8 with SMTP id pi8so28340612igb.1 for ; Sat, 13 Jun 2015 07:48:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=yj+39ajKhdIXTqfBanyi69I/ef0cE8u+MIivcQx0BSE=; b=AYyjmI9ZndJBKiKXSg1PGVCxI8dCzDBWCW1tzkC3aC4bmNSGOJ97G2lFPzGRFXhOP/ ZStx+lXyQOlcGV3Fiv7GcwrEGRIdH9dSnpTjbUPdCMEqHIzxpala45GOxLRnmuCLn2th j6Nzkf/drSU5vxML4xTJOWep0+8ylDp4Zgiu9CkGTVQX7sgkQH7mZNTY+Qjh66OXL6vX LQl1zOmR3z7nP5b/cKoTLgF9+RAO0URPcEkxRD4GZFClhlgbwm4iUuV3AAmmDvFEp4KS efuluiuGDNTNRvK+jE7eaJUwOXO6TRLoLejwImmaDZK8dNYIsA5U0wFmKb17EsRepIxA YKOw== X-Gm-Message-State: ALoCoQmJLK3pzh7suuX6T1du2vNFcEhgjSItir/mTQM8i77su0MgielAKVGQ3genxXbrQNSE86Ot X-Received: by 10.50.79.202 with SMTP id l10mr10837881igx.7.1434206931087; Sat, 13 Jun 2015 07:48:51 -0700 (PDT) Received: from [10.65.211.160] ([137.122.64.70]) by mx.google.com with ESMTPSA id o200sm4761682ioo.43.2015.06.13.07.48.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 13 Jun 2015 07:48:49 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r284198 - head/bin/ls Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <557C3D9D.5050905@freebsd.org> Date: Sat, 13 Jun 2015 10:48:47 -0400 Cc: Steve Kargl , Alexander Kabaev , Marcel Moolenaar , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <5918EB58-8E32-4D03-87BB-90AF5DA97E36@bsdimp.com> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <557C3D9D.5050905@freebsd.org> To: Julian Elischer X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 14:48:58 -0000 --Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Jun 13, 2015, at 10:26 AM, Julian Elischer = wrote: >=20 > On 6/13/15 10:49 AM, Steve Kargl wrote: >> On Fri, Jun 12, 2015 at 08:43:09PM -0400, Alexander Kabaev wrote: >>> On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) >>> Marcel Moolenaar wrote: >>>=20 >>>> Author: marcel >>>> Date: Wed Jun 10 01:27:38 2015 >>>> New Revision: 284198 >>>> URL: https://svnweb.freebsd.org/changeset/base/284198 >>>>=20 >>>> Log: >>>> Convert ls(1) to use libxo(3). >>>> Obtained from: Phil Shafer >>>> Sponsored by: Juniper Networks, Inc. >>>>=20 >>> >>>=20 >>> This broke all code that pipes output of the ls command to pipeline, >>> such as 'ls | wc -l'. ls never exits and never output anything. Is >>> there any purpose to libxo other than breaking stuff, which it = achieves >>> so splendidly? >>>=20 >> -1 for libxo, which also makes code almost unreadable. > +1 of the -1 >=20 > my personal vote is to revert all libxo changes and banish it from = /usr/src. >=20 > "not the way to solve the problem in question". It isn=92t even wrong=85. I think that we shouldn=92t integrate any more libxo stuff until all the = known bugs in the stuff that=92s already been converted is fixed. For example, gstat=92s =91q=92 function now needs a carriage = return before it will quit. That=92s insane. And the twisty maze of = modifications has made it rather an uber-pita to figure out WTF I need to do to un-F this up. But back to the topic at hand. libxo for ls? Really? WTF were you thinking? I know the cat -v paper is a bit of an extreme viewpoint, but all the libxo integration can be used a poster child for Pike=92s worries=85 Warner --Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVfELQAAoJEGwc0Sh9sBEAOjUP/24BvZ9SJcpDS67Nun3RqpSH FBPLryJnEoMimCKbuEqMdyqeIJrUePGIunzCo0qdXn5wUlFcJN9aCnm0//Pt5w5D qGJY/KIvD1pPXCyOEoku+p7SE4dOZzQje5vFQ5BnThW+r5Ptz04OqvCnSO9BaQ5E nvB/hYajXrqKrz8fACkTQxrMpiELWItShIFqRUGNP5IehwwzPwo/4UHcNobhNYNq rjXl6oqzPtWhQpbLkQuDqCkCICuTFlkuF2sn2p3XwKU2p0xQpJu9AaWMvp73fObM TWr0kdl6NYkZOmqgjpDVwlUYQD4v2VVz/bmM70g17CvvwP/ZervxrkfbQhB8Nt69 cOby2XiqBX6QpYHtSh7cJSFobftApfjZBgRoKPqIVd+34mGu967tkgPZ2A04wXFp QIS+ncr5gCppwCEK6IYAM/xiBI5sNjI0V0GUk7WwX1a93bPmCoLNYwCrDDgHGNdd XsmMYpNZ5QRCIWGgTjj8MuhbL0Mbm8t6fowdlmh9RpxvqgRGixuRYtk695qETxGW rlBum2ni43heSnPR2j2zUDKQghFrEfleWldIxdVQHGiKBoJ2w9eT++xPrcVuEScz 6Rixc70JRS2NiETpEV4lfdRMi6hb/5bOOPY3v3mARvFsi3qbDV9pGhb2DEuz4gP+ dZ2Vn6/VSBdD7lF6wML+ =lxiN -----END PGP SIGNATURE----- --Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686--