From owner-cvs-all@FreeBSD.ORG Mon Feb 18 12:50:38 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B36A916A419; Mon, 18 Feb 2008 12:50:38 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 6ED5C13C442; Mon, 18 Feb 2008 12:50:38 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id AF3AB2092; Mon, 18 Feb 2008 13:50:34 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.3/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 9DEB82091; Mon, 18 Feb 2008 13:50:34 +0100 (CET) Received: by ds4.des.no (Postfix, from userid 1001) id 778688449D; Mon, 18 Feb 2008 13:50:34 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Yar Tikhiy References: <200802141704.m1EH4VL4099009@repoman.freebsd.org> Date: Mon, 18 Feb 2008 13:50:34 +0100 In-Reply-To: <200802141704.m1EH4VL4099009@repoman.freebsd.org> (Yar Tikhiy's message of "Thu\, 14 Feb 2008 17\:04\:31 +0000 \(UTC\)") Message-ID: <86y79i5syt.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 12:50:38 -0000 Yar Tikhiy writes: > Log: > In the new order of things dictated by nmount(2), a read-only mount > is to be requested via a "ro" option. At the same time, MNT_RDONLY > is gradually becoming an indicator of the current state of the FS > instead of a command flag. Today passing MNT_RDONLY alone to the > kernel's mount machinery will lead to various glitches. (See the > PRs for examples.) >=20=20=20 > Therefore mount the root FS with a "ro" option instead of the > MNT_RDONLY flag. (Note that MNT_RDONLY still is added to the mount > flags internally, by vfs_donmount(), if "ro" was specified.) Can you guarantee that this will not f*** up the bootp / dhcp + nfsroot case? There are dragons in that code which were decidedly not funny to track down and fix. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no