From owner-cvs-src@FreeBSD.ORG Tue Sep 19 19:04:53 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFE8216A407; Tue, 19 Sep 2006 19:04:53 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail30.syd.optusnet.com.au (mail30.syd.optusnet.com.au [211.29.133.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40FF143D45; Tue, 19 Sep 2006 19:04:52 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail30.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k8JJ4odZ006049 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 20 Sep 2006 05:04:51 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k8JJ4obS003289; Wed, 20 Sep 2006 05:04:50 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k8JJ4n8j003288; Wed, 20 Sep 2006 05:04:49 +1000 (EST) (envelope-from peter) Date: Wed, 20 Sep 2006 05:04:49 +1000 From: Peter Jeremy To: Jung-uk Kim Message-ID: <20060919190449.GC720@turion.vk2pj.dyndns.org> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <200609181901.47414.jkim@FreeBSD.org> <200609191352.37338.jhb@freebsd.org> <200609191431.01649.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ALfTUftag+2gvp1h" Content-Disposition: inline In-Reply-To: <200609191431.01649.jkim@FreeBSD.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 19:04:54 -0000 --ALfTUftag+2gvp1h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: >On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: >> Which I'm about to kill hopefully. Please let's fix this the right >> way and not hack it any further. > >Sure, no problem. But I don't think we can DTRT on -STABLE without=20 >breaking API. Can we? I've had a quick look into this problem because I extensively use VLANs on a bge and discovered that I no longer have VLAN tag details (which makes packet tracing a nuisance). As far as I can see, there is nothing preventing bpf_tap() and bpf_mtap2() being doctored to undo the VLAN detagging so that bpf_filter() is passed a mbuf chain that looks like an 802.1Q ethernet frame: Dummy up an mbuf (as bpf_mtap2() does) that contains the MAC addresses from the incoming data followed by the 802.1Q packet type and tag information, with m_next pointing to the byte after the MAC addresses in the original data. --=20 Peter Jeremy --ALfTUftag+2gvp1h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFED9R/opHv/APuIcRAvXeAJ9G24xHV0g6/U1Gnu1dbL3UnaNymgCfT2od 2koKYRn3v1+wPVmAQw8m5rg= =6BOp -----END PGP SIGNATURE----- --ALfTUftag+2gvp1h--