Date: Thu, 15 Feb 2007 13:46:33 +0100 From: "Pascal Hofstee" <caelian@gmail.com> To: "Robert Watson" <rwatson@freebsd.org> Cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, hackers@freebsd.org Subject: Re: a question regarding <sys/shm.h> Message-ID: <d8a0b7620702150446g5638b86aw3d9124d5b1a7ecd7@mail.gmail.com> In-Reply-To: <20070131105024.L91177@fledge.watson.org> References: <45C04593.2090704@gmail.com> <20070131085206.GW892@turion.vk2pj.dyndns.org> <45C06167.60401@gmail.com> <86odofjyua.fsf@dwp.des.no> <20070131105024.L91177@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_133511_19540578.1171543593127 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 1/31/07, Robert Watson <rwatson@freebsd.org> wrote: > If we do decide to go ahead with the ABI change, there are a number of other > things that should be done simultaneously, such as changing the uid and gid > fields to uid_t and gid_t. I would very much like to see the ABI change > happen, and the first step (breaking out kernel from user structures) has been > done already as part of the MAC work. The next step is to add routines that > translate internal/external formats, which isn't hard, but requires a moderate > pile of code to do (as well as great care :-). Well .. i finally found some spare time to have a closer look at the "shm_segsz" issue ... and noticed there were actually a very limited number of direct uses of the shm_segsz struct member (26 lines in the entire /usr/src tree) I have attached a patchset that should change shm_segsz to size_t. There were however 2 to 3 locations all regarding compat code (ibcs2, svr4 and COMPAT_43) where i opted to stay on the clear side and not touch anything, the rest was fairly straightforward as should be obvious from the diff. I checked to make sure no function prototypes changed anywhere. Please have a look at the attached patch (available at http://callisto.offis.uni-oldenburg.de/shm_segsz-int2size_t.diff in case the attachment gets stripped off by the mailinglist software) and provide any feedback where appropriate. -- Pascal Hofstee ------=_Part_133511_19540578.1171543593127 Content-Type: text/x-patch; name="shm_segsz-int2size_t.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="shm_segsz-int2size_t.diff" X-Attachment-Id: f_ey76shrw ZGlmZiAtcnd1QmIgc3JjLnJlZi9saWIvbGliYy9zeXMvc2htY3RsLjIgc3JjL2xpYi9saWJjL3N5 cy9zaG1jdGwuMgotLS0gc3JjLnJlZi9saWIvbGliYy9zeXMvc2htY3RsLjIJVGh1IEZlYiAxNSAw OTo1NTowMSAyMDA3CisrKyBzcmMvbGliL2xpYmMvc3lzL3NobWN0bC4yCVRodSBGZWIgMTUgMDk6 NTY6NDkgMjAwNwpAQCAtMTAwLDcgKzEwMCw3IEBACiAuQmQgLWxpdGVyYWwKIHN0cnVjdCBzaG1p ZF9kcyB7CiAgICAgc3RydWN0IGlwY19wZXJtIHNobV9wZXJtOyAgIC8qIG9wZXJhdGlvbiBwZXJt aXNzaW9uIHN0cnVjdHVyZSAqLwotICAgIGludCAgICAgICAgICAgICBzaG1fc2Vnc3o7ICAvKiBz aXplIG9mIHNlZ21lbnQgaW4gYnl0ZXMgKi8KKyAgICBzaXplX3QgICAgICAgICAgc2htX3NlZ3N6 OyAgLyogc2l6ZSBvZiBzZWdtZW50IGluIGJ5dGVzICovCiAgICAgcGlkX3QgICAgICAgICAgIHNo bV9scGlkOyAgIC8qIHByb2Nlc3MgSUQgb2YgbGFzdCBzaGFyZWQgbWVtb3J5IG9wICovCiAgICAg cGlkX3QgICAgICAgICAgIHNobV9jcGlkOyAgIC8qIHByb2Nlc3MgSUQgb2YgY3JlYXRvciAqLwog ICAgIHNob3J0ICAgICAgICAgICBzaG1fbmF0dGNoOyAvKiBudW1iZXIgb2YgY3VycmVudCBhdHRh Y2hlcyAqLwpkaWZmIC1yd3VCYiBzcmMucmVmL3N5cy9jb21wYXQvZnJlZWJzZDMyL2ZyZWVic2Qz Ml9taXNjLmMgc3JjL3N5cy9jb21wYXQvZnJlZWJzZDMyL2ZyZWVic2QzMl9taXNjLmMKLS0tIHNy Yy5yZWYvc3lzL2NvbXBhdC9mcmVlYnNkMzIvZnJlZWJzZDMyX21pc2MuYwlUaHUgRmViIDE1IDA5 OjQ5OjUzIDIwMDcKKysrIHNyYy9zeXMvY29tcGF0L2ZyZWVic2QzMi9mcmVlYnNkMzJfbWlzYy5j CVRodSBGZWIgMTUgMDk6NTk6MDUgMjAwNwpAQCAtMTQ0NSw3ICsxNDQ1LDcgQEAKIH07CiBzdHJ1 Y3Qgc2htaWRfZHMzMiB7CiAJc3RydWN0IGlwY19wZXJtMzIgc2htX3Blcm07Ci0JaW50MzJfdAkJ c2htX3NlZ3N6OworCXNpemVfdAkJc2htX3NlZ3N6OwogCWludDMyX3QJCXNobV9scGlkOwogCWlu dDMyX3QJCXNobV9jcGlkOwogCWludDE2X3QJCXNobV9uYXR0Y2g7CmRpZmYgLXJ3dUJiIHNyYy5y ZWYvc3lzL2NvbXBhdC9saW51eC9saW51eF9pcGMuYyBzcmMvc3lzL2NvbXBhdC9saW51eC9saW51 eF9pcGMuYwotLS0gc3JjLnJlZi9zeXMvY29tcGF0L2xpbnV4L2xpbnV4X2lwYy5jCVRodSBGZWIg MTUgMDk6NDk6NTMgMjAwNworKysgc3JjL3N5cy9jb21wYXQvbGludXgvbGludXhfaXBjLmMJVGh1 IEZlYiAxNSAxMDowMzo0MyAyMDA3CkBAIC0xODcsNyArMTg3LDcgQEAKIAogc3RydWN0IGxfc2ht aWRfZHMgewogCXN0cnVjdCBsX2lwY19wZXJtCXNobV9wZXJtOwotCWxfaW50CQkJc2htX3NlZ3N6 OworCWxfc2l6ZV90CQlzaG1fc2Vnc3o7CiAJbF90aW1lX3QJCXNobV9hdGltZTsKIAlsX3RpbWVf dAkJc2htX2R0aW1lOwogCWxfdGltZV90CQlzaG1fY3RpbWU7CmRpZmYgLXJ3dUJiIHNyYy5yZWYv c3lzL3N5cy9zaG0uaCBzcmMvc3lzL3N5cy9zaG0uaAotLS0gc3JjLnJlZi9zeXMvc3lzL3NobS5o CVRodSBGZWIgMTUgMDk6NTI6MTMgMjAwNworKysgc3JjL3N5cy9zeXMvc2htLmgJVGh1IEZlYiAx NSAxMDoxNDo1NiAyMDA3CkBAIC03Nyw3ICs3Nyw3IEBACiAKIHN0cnVjdCBzaG1pZF9kcyB7CiAJ c3RydWN0IGlwY19wZXJtIHNobV9wZXJtOwkvKiBvcGVyYXRpb24gcGVybWlzc2lvbiBzdHJ1Y3R1 cmUgKi8KLQlpbnQgICAgICAgICAgICAgc2htX3NlZ3N6OwkvKiBzaXplIG9mIHNlZ21lbnQgaW4g Ynl0ZXMgKi8KKwlzaXplX3QgICAgICAgICAgc2htX3NlZ3N6OwkvKiBzaXplIG9mIHNlZ21lbnQg aW4gYnl0ZXMgKi8KIAlwaWRfdCAgICAgICAgICAgc2htX2xwaWQ7ICAgLyogcHJvY2VzcyBJRCBv ZiBsYXN0IHNoYXJlZCBtZW1vcnkgb3AgKi8KIAlwaWRfdCAgICAgICAgICAgc2htX2NwaWQ7CS8q IHByb2Nlc3MgSUQgb2YgY3JlYXRvciAqLwogCXNob3J0CQlzaG1fbmF0dGNoOwkvKiBudW1iZXIg b2YgY3VycmVudCBhdHRhY2hlcyAqLwpkaWZmIC1yd3VCYiBzcmMucmVmL3Rvb2xzL3JlZ3Jlc3Np b24vc3lzdnNobS9zaG10ZXN0LmMgc3JjL3Rvb2xzL3JlZ3Jlc3Npb24vc3lzdnNobS9zaG10ZXN0 LmMKLS0tIHNyYy5yZWYvdG9vbHMvcmVncmVzc2lvbi9zeXN2c2htL3NobXRlc3QuYwlUaHUgRmVi IDE1IDA5OjQ5OjM2IDIwMDcKKysrIHNyYy90b29scy9yZWdyZXNzaW9uL3N5c3ZzaG0vc2htdGVz dC5jCVRodSBGZWIgMTUgMTA6MjI6MjQgMjAwNwpAQCAtMjQ3LDggKzI0Nyw4IEBACiAJICAgIHNw LT5zaG1fcGVybS5jdWlkLCBzcC0+c2htX3Blcm0uY2dpZCwKIAkgICAgc3AtPnNobV9wZXJtLm1v ZGUgJiAwNzc3KTsKIAotCXByaW50Zigic2Vnc3ogJWx1LCBscGlkICVkLCBjcGlkICVkLCBuYXR0 Y2ggJXVcbiIsCi0JICAgICh1X2xvbmcpc3AtPnNobV9zZWdzeiwgc3AtPnNobV9scGlkLCBzcC0+ c2htX2NwaWQsCisJcHJpbnRmKCJzZWdzeiAlenUsIGxwaWQgJWQsIGNwaWQgJWQsIG5hdHRjaCAl dVxuIiwKKwkgICAgc3AtPnNobV9zZWdzeiwgc3AtPnNobV9scGlkLCBzcC0+c2htX2NwaWQsCiAJ ICAgIHNwLT5zaG1fbmF0dGNoKTsKIAogCXByaW50ZigiYXRpbWU6ICVzIiwgY3RpbWUoJnNwLT5z aG1fYXRpbWUpKTsKZGlmZiAtcnd1QmIgc3JjLnJlZi91c3IuYmluL2lwY3MvaXBjcy5jIHNyYy91 c3IuYmluL2lwY3MvaXBjcy5jCi0tLSBzcmMucmVmL3Vzci5iaW4vaXBjcy9pcGNzLmMJVGh1IEZl YiAxNSAwOTo0OToxNSAyMDA3CisrKyBzcmMvdXNyLmJpbi9pcGNzL2lwY3MuYwlUaHUgRmViIDE1 IDEwOjIwOjI3IDIwMDcKQEAgLTQzOSw3ICs0MzksNyBAQAogCQkJCQkJICAgIGtzaG1wdHItPnUu c2htX25hdHRjaCk7CiAKIAkJCQkJaWYgKG9wdGlvbiAmIEJJR0dFU1QpCi0JCQkJCQlwcmludGYo IiAlMTJkIiwKKwkJCQkJCXByaW50ZigiICUxMnp1IiwKIAkJCQkJCSAgICBrc2htcHRyLT51LnNo bV9zZWdzeik7CiAKIAkJCQkJaWYgKG9wdGlvbiAmIFBJRCkK ------=_Part_133511_19540578.1171543593127--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d8a0b7620702150446g5638b86aw3d9124d5b1a7ecd7>