From owner-freebsd-emulation@FreeBSD.ORG Wed Jan 8 14:58:51 2014 Return-Path: Delivered-To: vbox@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B57D36CF for ; Wed, 8 Jan 2014 14:58:51 +0000 (UTC) Received: from mail-ob0-x22b.google.com (mail-ob0-x22b.google.com [IPv6:2607:f8b0:4003:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 76ADA11BC for ; Wed, 8 Jan 2014 14:58:51 +0000 (UTC) Received: by mail-ob0-f171.google.com with SMTP id wp18so1804635obc.2 for ; Wed, 08 Jan 2014 06:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluelife.at; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=U12F85n70L+G+/856sk+7aopDUvK4N0lVyZ9dF+jKnc=; b=ZOr6k7t905QnWasiGgXYoAcOvhaGfU1C9/2a8W0EtlR7CN1A57DNE+ug5xh0/2ITZw /OdHhB1DRtENxV6D9uVT1UYhg7YRxUd1GEc/AGe/P2KBVsEWKHQC7aee/Gei2mVaktnQ 38AE5xPMoDxCSku0R6v9JP6812+UyV3Sm3J2M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=U12F85n70L+G+/856sk+7aopDUvK4N0lVyZ9dF+jKnc=; b=GZifMUFgj7HsRs0E6hq4CGXRcFvg9GDUfDMV73S5PgV4BkjJ1IBpY/DUHFLHzntffu xjjGIWdd5RzR02kbOGCGBlGWQe0nql3pJsh0PWr9CeJ9U+MkDk8e736BgqQFsT4sEDxM isMrXNT1wRWLKiDtr/igCyW4J+56dn3XDf/RQxqM8EKxyECz57Dj3QgYRIoJTxddWkGn tEyYpnYyUbEeS2izsmRswtaBUlcUBRkvI2MOiafthiI8ixYaO51Kra1auFxpNdmK6aFt U5ydQ6YlbaJ6IU3rx6dwqYqHemsl1o2d23Eubk4EBvMIjnxjixgFfyeLwMMjNEQCuO9X GLNw== X-Gm-Message-State: ALoCoQkZ3t2a/BECpU6nQShW4PNTuSEPSHjHe8BuHi0QrhsaZgeycP0JYjZ9ND/q+jgLBS2GPgCN MIME-Version: 1.0 X-Received: by 10.182.246.7 with SMTP id xs7mr498006obc.81.1389193130599; Wed, 08 Jan 2014 06:58:50 -0800 (PST) Sender: decke@bluelife.at Received: by 10.76.154.2 with HTTP; Wed, 8 Jan 2014 06:58:50 -0800 (PST) X-Originating-IP: [80.123.233.199] In-Reply-To: References: Date: Wed, 8 Jan 2014 15:58:50 +0100 X-Google-Sender-Auth: j1pD_F9QmYH19bSJwLVYQ5u8hd8 Message-ID: Subject: Re: virtualbox-ose: missing OpenGL dependency From: =?ISO-8859-1?Q?Bernhard_Fr=F6hlich?= To: Jimmy Olgeni Content-Type: text/plain; charset=ISO-8859-1 X-Mailman-Approved-At: Wed, 08 Jan 2014 16:24:55 +0000 Cc: vbox@freebsd.org X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jan 2014 14:58:51 -0000 On Wed, Jan 8, 2014 at 12:29 PM, Jimmy Olgeni wrote: > > Hello, > > After the latest QT4 changes I noticed that VirtualBox needs a dependency on > graphics/qt4-opengl, so here it is (checked on poudriere): > > Index: Makefile > =================================================================== > --- Makefile (revision 339028) > +++ Makefile (working copy) > @@ -27,7 +27,8 @@ > python:${PORTSDIR}/lang/python > LIB_DEPENDS= libpng.so:${PORTSDIR}/graphics/png \ > libxslt.so:${PORTSDIR}/textproc/libxslt \ > - libcurl.so:${PORTSDIR}/ftp/curl > + libcurl.so:${PORTSDIR}/ftp/curl \ > + libQtOpenGL.so:${PORTSDIR}/graphics/qt4-opengl > RUN_DEPENDS= > ${KMODDIR}/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod \ > cdrecord:${PORTSDIR}/sysutils/cdrtools You might be correct but the patch looks wrong to me so I propose the following. Index: emulators/virtualbox-ose/Makefile =================================================================== --- emulators/virtualbox-ose/Makefile (revision 339142) +++ emulators/virtualbox-ose/Makefile (working copy) @@ -124,7 +124,7 @@ .if ${PORT_OPTIONS:MQT4} QT_NONSTANDARD= yes -USE_QT4= gui network moc_build uic_build rcc_build linguist +USE_QT4= gui network moc_build opengl uic_build rcc_build linguist INSTALLS_ICONS= yes VBOX_FRONTENDS+=VirtualBox VBoxTestOGL -- Bernhard Froehlich http://www.bluelife.at/