Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Jan 2014 15:58:50 +0100
From:      =?ISO-8859-1?Q?Bernhard_Fr=F6hlich?= <decke@FreeBSD.org>
To:        Jimmy Olgeni <olgeni@olgeni.com>
Cc:        vbox@freebsd.org
Subject:   Re: virtualbox-ose: missing OpenGL dependency
Message-ID:  <CAE-m3X3c4vjU3J60JfgvzqKiEZhW8b-3taRt=WnPkEcVCA=CeA@mail.gmail.com>
In-Reply-To: <alpine.BSF.2.00.1401081224260.17492@olgeni.olgeni>
References:  <alpine.BSF.2.00.1401081224260.17492@olgeni.olgeni>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 8, 2014 at 12:29 PM, Jimmy Olgeni <olgeni@olgeni.com> wrote:
>
> Hello,
>
> After the latest QT4 changes I noticed that VirtualBox needs a dependency on
> graphics/qt4-opengl, so here it is (checked on poudriere):
>
> Index: Makefile
> ===================================================================
> --- Makefile    (revision 339028)
> +++ Makefile    (working copy)
> @@ -27,7 +27,8 @@
>                 python:${PORTSDIR}/lang/python
>  LIB_DEPENDS=   libpng.so:${PORTSDIR}/graphics/png \
>                 libxslt.so:${PORTSDIR}/textproc/libxslt \
> -               libcurl.so:${PORTSDIR}/ftp/curl
> +               libcurl.so:${PORTSDIR}/ftp/curl \
> +               libQtOpenGL.so:${PORTSDIR}/graphics/qt4-opengl
>  RUN_DEPENDS=
> ${KMODDIR}/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod \
>                 cdrecord:${PORTSDIR}/sysutils/cdrtools

You might be correct but the patch looks wrong to me so I propose the following.

Index: emulators/virtualbox-ose/Makefile
===================================================================
--- emulators/virtualbox-ose/Makefile    (revision 339142)
+++ emulators/virtualbox-ose/Makefile    (working copy)
@@ -124,7 +124,7 @@

 .if ${PORT_OPTIONS:MQT4}
 QT_NONSTANDARD=    yes
-USE_QT4=    gui network moc_build uic_build rcc_build linguist
+USE_QT4=    gui network moc_build opengl uic_build rcc_build linguist
 INSTALLS_ICONS=    yes
 VBOX_FRONTENDS+=VirtualBox VBoxTestOGL

-- 
Bernhard Froehlich
http://www.bluelife.at/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-m3X3c4vjU3J60JfgvzqKiEZhW8b-3taRt=WnPkEcVCA=CeA>