From owner-svn-src-all@FreeBSD.ORG  Mon Feb 16 01:25:31 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 17B8CA13;
 Mon, 16 Feb 2015 01:25:31 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8D444172;
 Mon, 16 Feb 2015 01:25:29 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1G1PSY7047175
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 16 Feb 2015 04:25:28 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1G1PS6a047174;
 Mon, 16 Feb 2015 04:25:28 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 16 Feb 2015 04:25:28 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Craig Rodrigues <rodrigc@FreeBSD.org>
Subject: Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID: <20150216012528.GA15484@FreeBSD.org>
References: <201501060903.t06934qp081875@svn.freebsd.org>
 <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com>
 <20150122222314.GO15484@FreeBSD.org>
 <CAG=rPVc2YLB-3ZyxDZTxDpkt6R8E_Sf1U+WWwKrFB2dxTXGENQ@mail.gmail.com>
 <20150215190100.GQ15484@FreeBSD.org>
 <CAG=rPVfK-Qmh7E_+-Mmo8kTrDWq=++yVCzHNaQ=5pQh7aSaESQ@mail.gmail.com>
 <CAG=rPVd8VkPLHDQqBZPWmFA93+R26qUAwQGT2YUpxYJ8hZFJHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG=rPVd8VkPLHDQqBZPWmFA93+R26qUAwQGT2YUpxYJ8hZFJHA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 Nikos Vassiliadis <nvass@gmx.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 01:25:31 -0000

On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote:
C> By the way, it would be helpful if you could provide feedback in
C> Phabricator.  When I created those Phabricator reviews, I added
C> you as a reviewer to all of them, so you can't say that you didn't see
C> the patches.
C> You did not provide feedback on any of them:
C> 
C> https://reviews.freebsd.org/D1309
C> https://reviews.freebsd.org/D1312
C> https://reviews.freebsd.org/D1313
C> https://reviews.freebsd.org/D1315
C> 
C> Please take some time to go and provide feedback in those
C> reviews, so that a better patch can be made that makes you happy.

Did you address all problems that arised after code was committed?

Please do, otherwise my review would require me to cut-n-paste from
my own emails.

-- 
Totus tuus, Glebius.