From owner-freebsd-current@freebsd.org Thu Jul 25 18:13:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 844EFAAB2D for ; Thu, 25 Jul 2019 18:13:30 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A6AA8E582; Thu, 25 Jul 2019 18:13:30 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w6PEdOWQ1JGGp67/mu6JrCfRprAbW5qKuw1WyaPUHwE=; b=DfXZHFwG03JZURiOVbIRkhZv3P ozh4g5ccwul4BYo1hCNPk1CWk7Nxz9KpZ4FiIq1IHCVXFO92HME839Phn6dkH9CKfy0P5bj8Z0oQ/ zp4H3HTWW8oeKXZ1JVy1Una7DEWSdpoNNYCX3yQb4XC9sn5BmKJ6M74AilmQdxplFQTxiNzstEpmj DXwe4hT8aeTo9xa8yWGDMVfM9V7CGWG0BWsCPGvqOCZU6LISvGUZ02+NaYwdhtndHI8W/L/k+GjJb gxT8qQgzuvv8tHZu5kYm0wivxbtAzVwmluDscjsrkz9b2nu4b8cJZeBcGgKCJsN2IAIEbTlAYinig 4wNnBN+A==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:15535 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hqiF7-0003bE-KW; Thu, 25 Jul 2019 13:13:29 -0500 Received: from 2600:1700:210:b180:f4ae:ab2e:e462:6b19 by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Thu, 25 Jul 2019 13:13:29 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 25 Jul 2019 13:13:29 -0500 From: Larry Rosenman To: Alan Somers Cc: Freebsd current Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build In-Reply-To: References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> Message-ID: X-Sender: ler@FreeBSD.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 18:13:30 -0000 On 07/25/2019 1:10 pm, Alan Somers wrote: > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman > wrote: >> >> Um.... Who broke this? >> >> /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared identifier >> 'false' >> return (false); >> ^ >> /usr/src/sys/sys/refcount.h:68:12: error: use of undeclared identifier >> 'true' >> return (true); >> ^ >> /usr/src/sys/sys/refcount.h:81:11: error: use of undeclared identifier >> 'false' >> return (false); >> ^ >> /usr/src/sys/sys/refcount.h:90:10: error: use of undeclared identifier >> 'true' >> return (true); >> ^ >> /usr/src/sys/sys/refcount.h:106:12: error: use of undeclared >> identifier >> 'false' >> return (false); >> ^ >> /usr/src/sys/sys/refcount.h:108:12: error: use of undeclared >> identifier >> 'true' >> return (true); >> ^ >> /usr/src/sys/sys/refcount.h:121:12: error: use of undeclared >> identifier >> 'false' >> return (false); >> ^ >> /usr/src/sys/sys/refcount.h:123:12: error: use of undeclared >> identifier >> 'true' >> return (true); >> ^ >> 8 errors generated. >> *** Error code 1 >> >> Stop. >> make[2]: stopped in >> /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2/lib >> *** Error code 1 >> >> Stop. >> make[1]: stopped in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2 >> *** Error code 1 >> >> Stop. >> make: stopped in /usr/ports/sysutils/lsof >> >> -- >> Larry Rosenman http://people.freebsd.org/~ler >> Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org >> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to >> "freebsd-current-unsubscribe@freebsd.org" > > > "svn blame" suggests r350199 by kib. However, refcount.h should only > be included if lsof defines _KERNEL, which normal programs shouldn't. > So I think this should be considered a bug in lsof. > -Alan we *HAVE* to define _KERNEL, to get at the kernel structures..... -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106