From owner-freebsd-gnome@FreeBSD.ORG Wed Apr 15 06:46:08 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EFFC106566B for ; Wed, 15 Apr 2009 06:46:08 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from natial.ongs.co.jp (natial.ongs.co.jp [202.216.246.90]) by mx1.freebsd.org (Postfix) with ESMTP id 4EEAA8FC15 for ; Wed, 15 Apr 2009 06:46:08 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from parancell.ongs.co.jp (dullmdaler.ongs.co.jp [202.216.246.94]) by natial.ongs.co.jp (Postfix) with ESMTPSA id 2C57C125422; Wed, 15 Apr 2009 15:46:07 +0900 (JST) Message-ID: <49E582AE.20506@ongs.co.jp> Date: Wed, 15 Apr 2009 15:46:06 +0900 From: Daichi GOTO User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Joe Marcus Clarke References: <49E3FC71.7090904@ongs.co.jp> <1239681274.1304.93.camel@shumai.marcuscom.com> <49E41E27.6090808@ongs.co.jp> <1239776833.78860.30.camel@shumai.marcuscom.com> In-Reply-To: <1239776833.78860.30.camel@shumai.marcuscom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: Suggest: gdm_lang flag for gdm startup language X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 06:46:08 -0000 Joe Marcus Clarke wrote: > On Tue, 2009-04-14 at 14:24 +0900, Daichi GOTO wrote: >> Joe Marcus Clarke wrote: >>> On Tue, 2009-04-14 at 12:01 +0900, Daichi GOTO wrote: >>>> Hi gnome guys, >>>> >>>> I want to suggest follow patch to /usr/local/etc/rc.d/gdm >>>> RGng script setting default startup language. With follow >>>> patch, someone want to use gdm as non-English default, e.g., >>>> adding gdm_lang="ja_JP.UTF-8" to /etc/rc.conf is anwser. >>>> >>>> It is bothering me every day first time I must set Japanese >>>> when gdm login display. Do you have any ideas? If you have >>>> no objection, I want to commit to /usr/ports/x11/gdm/files/gdm.in >>> We already have a procedure for this documented on the FAQ: >>> >>> http://www.freebsd.org/gnome/docs/faq2.html#q29 >>> >>> The /etc/profile method is preferred as there is already support for it >>> upstream. >>> >>> Joe >> Yes, I know /etc/profile method, and I do not recognize that >> is good idea for this issue. In fact, that is very bad idea >> I guess. We should prevent /etc/profile method ASAP. >> >> Reasons: >> >> 1. /etc/profile affects others than gdm. FreeBSD console >> does not support non-English displaying. And some >> applications cannot been built without LANG=C. So, to >> set LANG=??? (e.g. ja-JP.UTF-8) on /etc/profile is >> very bad idea. The /etc/profile method affects to many >> phenomena. >> >> 2. I suggest controlling application behavior installed >> by Ports Collection in /etc/rc.conf is clear and simple >> way. Should we (especially for non-English user) edit >> /etc/rc.conf and /etc/profile every time updated relative >> components? It is bothering matter. >> >> I'm thinking adding gdm_lang="ja_JP.UTF-8" to /etc/rc.conf >> is very clear and easy understanding for common user of Gnome. >> How do you make of it?? > > I admit I'm not the best person to evaluate i18n or l10n solutions. I'm > happy with en_US or even ASCII. I think bland is going to look at > restoring login cap support to GDM, but I when the freeze ends I'll look > at committing your suggestion. > > Joe Oh, really? Thank you very much! :) >>>> Thanks :) >>>> >>>> >>>> --- gdm.orig 2009-04-14 11:55:01.000000000 +0900 >>>> +++ gdm 2009-04-14 11:54:36.000000000 +0900 >>>> @@ -15,6 +15,7 @@ >>>> >>>> gdm_enable=${gdm_enable-${gnome_enable}} >>>> gdm_preserve_base_pam_conf=${gdm_preserve_base_pam_conf-NO} >>>> +gdm_lang=${gdm_lang-${LANG}} >>>> >>>> export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin >>>> >>>> @@ -54,7 +55,7 @@ >>>> sleep 1 >>>> iter=$(expr ${iter} + 1) >>>> done >>>> - ${command} ${gdm_flags} ) & >>>> + LANG=${gdm_lang} ${command} ${gdm_flags} ) & >>>> } >>>> >>>> load_rc_config ${name} -- Daichi GOTO, http://people.freebsd.org/~daichi