From owner-freebsd-stable@FreeBSD.ORG Thu Jul 4 17:34:04 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9A3D3F09; Thu, 4 Jul 2013 17:34:04 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by mx1.freebsd.org (Postfix) with ESMTP id 3010B12E3; Thu, 4 Jul 2013 17:34:03 +0000 (UTC) Received: from mail3.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id r64HY1HA022004; Thu, 4 Jul 2013 19:34:02 +0200 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail3.siemens.de (8.13.6/8.13.6) with ESMTP id r64HY13L017321; Thu, 4 Jul 2013 19:34:01 +0200 Received: (from localhost) by curry.mchp.siemens.de (8.14.7/8.14.7) id r64HY1bp016957; Date: Thu, 4 Jul 2013 19:34:01 +0200 From: Andre Albsmeier To: Konstantin Belousov Subject: Re: FreeBSD-9.1: machine reboots during snapshot creation, LORs found Message-ID: <20130704173401.GA3297@bali> References: <20130531122611.GA6607@bali> <201305311051.03157.jhb@freebsd.org> <20130616063942.GA72803@bali> <201306171530.31208.jhb@freebsd.org> <20130704051409.GA22021@bali> <20130704052440.GG91021@kib.kiev.ua> <20130704052659.GA23398@bali> <20130704061550.GI91021@kib.kiev.ua> <20130704142919.GA1798@bali> <20130704172528.GL91021@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130704172528.GL91021@kib.kiev.ua> X-Echelon: X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-stable@freebsd.org" , John Baldwin X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2013 17:34:04 -0000 On Thu, 04-Jul-2013 at 19:25:28 +0200, Konstantin Belousov wrote: > On Thu, Jul 04, 2013 at 04:29:19PM +0200, Andre Albsmeier wrote: > > OK, patch is applied. I will reboot the machine later > > and see what happens tomorrow in the morning. However, > > it might take a few days since the last 2 weeks all was > > fine. > > > > BTW, should this patch be used in general or is it just > > for debugging? My understanding is that it is something > > which could stay in the code... > > Patch is to improve debugging. That's what I suspected. > > I probably commit it after the issue is closed. Arguments against > the commit is that the change imposes small performance penalty > due to save and restore of the %ebp (I doubt that this is measureable > by any means). Also, arguably, such change should be done for all > functions in support.s, but bcopy() is the hot spot. Hmm, maybe it could simply get enabled conditionally through some kernel compile option which is off by default... -Andre