From owner-svn-src-all@freebsd.org Thu Feb 22 17:40:04 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75ABAF19FFD for ; Thu, 22 Feb 2018 17:40:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 02C386EE2D for ; Thu, 22 Feb 2018 17:40:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22d.google.com with SMTP id g21so6852301ioj.5 for ; Thu, 22 Feb 2018 09:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Z/b9ZdmBTfi7iozMNoDjfo21H4Svj6j2fY35Iq2eVvI=; b=0x4lLtC50oQ4J6PYqUq4D2Na+Acyefg0L1JEpVJMKv5oPdCoMpmV5PIMJwUWCDIrnE kmCbxyWHJ06egtDLlXaaSYJLEdRxaN3k3TXy8SuLe5prvg1DiEMcWPJEIOyUC5eQdLzj 93cRzzkmAc3qTGym9OvvOgr1FydsSM4o4X7920jOS1VLELguar2jYhvnl6NvcEZqjXv7 RWu82Nr/7QjNydT5jD53VBpItf27gcdgzrZQJu2x2f8tEC4rVeUjCN87m6BmwezVqYOm rzNpXnpcacgJYZMrM4ynrixPNJSXY1olmVCjmwWEri86ADa1bvGL0p3TYoX8yQI8JlCS oXzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Z/b9ZdmBTfi7iozMNoDjfo21H4Svj6j2fY35Iq2eVvI=; b=pRGPldBylQONcbvG6jkmtjsimpkA/sPKRfQOZ32emcOcfNF8XSQFRIV5KiQWNpBMVk BV0BSnlAzbdImAFutRd//UlyTV+AQepXqJv8SfJ3JqaS3kpC7f1hYniGPLuXSsh3Jf+V HbPRO/VfRLd24GMdPjzlqPMNiL73yuHKhkI2YanSZoqWgUu9GpHCp5mlMpkfMLWQGRyW n+mBkLOU5dr6l7LGAFRCitmkdeN6n8Y2324kGXfjFryiu/qroq1yCakVtJR6i2vmGDY9 uOEwRYfBFoGSgYbQa9GDnuUQZ69SJqB8jG2QulX2ETCzSra6zswPCeUkpZwG88U4CZ9y Jviw== X-Gm-Message-State: APf1xPCnNrQDIZf876yH2H6ZCCiB271Bsr7j8FSnkKL8zB6MD4mxA8mk 56hS9nkL3ULDPR8jZ9ix48EdcwqZm0E6+vNXkQUX1g== X-Google-Smtp-Source: AG47ELuT1RIbT6ftz+H3pQxU3ntXX+y0Lq+/H2axIvkkEbptAErQDa+b67tVqFvICLee0lmhbMsTQDa9qxzIiWHwvCQ= X-Received: by 10.107.2.6 with SMTP id 6mr9600103ioc.117.1519321203177; Thu, 22 Feb 2018 09:40:03 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Thu, 22 Feb 2018 09:40:02 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Warner Losh Date: Thu, 22 Feb 2018 10:40:02 -0700 X-Google-Sender-Auth: Ivh6b3eF-dnPROJSDdYmeq2UrXE Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Wojciech Macek Cc: Alan Somers , Kyle Evans , Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , =?UTF-8?Q?Micha=C5=82_Stanek?= Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 17:40:04 -0000 On Thu, Feb 22, 2018 at 9:49 AM, Wojciech Macek wrote: > Yes, I'm doing that right now. So far it seems everything is there, but > will confirm to be 100% sure. > > Warner, I'm very sorry for not waiting for your comments. The review was > dead for few days and I thought that all was already said, but maybe > should have waited a little longer... > Let me know what to do now. If you see any issues, I'll be more than happy > to fix them. Also, if you insist, we can revert it, but if no drastic > changes are required, I'd prefer to leave it as is and make iterational > fixes to this part. > I agree. Unless something surfaces that's utterly broken, that's the best path forward. So far the actual driver is coping well with the load I'm giving it and it wasn't too disruptive to other things I had going on.... I understand things get pushed in more quickly than reviews would like sometimes, so I'll look over the changes and see if all of the things I had issues with in the original patches were addressed. I know most of them have, but wanted to make sure before a final sign off is all... If there is stuff, I think it will be minor. Warner > Regards, > Wojtek > wma@ > > 2018-02-22 17:34 GMT+01:00 Warner Losh : > >> I know all about losing things during the rebase.... >> >> I'd be a lot happier if you could confirm that nothing else was lost. >> It's a large patch, which makes it impossible for others to do it... It >> seems to build, and seems to be working in the light testing I've done this >> morning... >> >> Warner >> >> >> On Thu, Feb 22, 2018 at 9:31 AM, Wojciech Macek wrote: >> >>> Thanks and sorry for troubles! >>> These lines must have got lost somewhere during rebase as we run >>> tinderbox with this patch yesterday. >>> >>> Regards, >>> Wojtek >>> wma@ >>> >>> 2018-02-22 17:22 GMT+01:00 Alan Somers : >>> >>>> On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: >>>> >>>>> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers >>>>> wrote: >>>>> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek >>>>> wrote: >>>>> > >>>>> >> Author: wma >>>>> >> Date: Thu Feb 22 13:32:31 2018 >>>>> >> New Revision: 329824 >>>>> >> URL: https://svnweb.freebsd.org/changeset/base/329824 >>>>> >> >>>>> >> Log: >>>>> >> NVMe: Add big-endian support >>>>> >> >>>>> >> Remove bitfields from defined structures as they are not portable. >>>>> >> Instead use shift and mask macros in the driver and nvmecontrol >>>>> >> application. >>>>> >> >>>>> >> NVMe is now working on powerpc64 host. >>>>> >> >>>>> >> Submitted by: Michal Stanek >>>>> >> Obtained from: Semihalf >>>>> >> Reviewed by: imp, wma >>>>> >> Sponsored by: IBM, QCM Technologies >>>>> >> Differential revision: https://reviews.freebsd.org/D13916 >>>>> >> >>>>> > >>>>> > It looks like this change broke the build with Clang: >>>>> > >>>>> >>>>> Fixed in r329827... all little endian arch's broken, not so great. =( >>>>> >>>> >>>> Fast work, Kyle. Thanks a bundle. >>>> -Alan >>>> >>> >>> >> >