Date: Sun, 05 Feb 2017 18:21:48 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 216627] multimedia/zoneminder and multimedia/zoneminder-h264: fail to build with clang 4.0 Message-ID: <bug-216627-13-0Wmy8iWENv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-216627-13@https.bugs.freebsd.org/bugzilla/> References: <bug-216627-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216627 --- Comment #4 from Jan Beich (mail not working) <jbeich@FreeBSD.org> --- Comment on attachment 179574 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179574 zoneminder patch Can you describe other changes? This is mainly for commit message. > +- if ( mem_ptr < 0 ) > ++ if ( mem_ptr < (void *)0 ) [...] > +- if ( mem_ptr > 0 ) > ++ if ( mem_ptr > (void *)0 ) mmap(2) returns MAP_FAILED on failure while shmat(2) returns (void *)-1. Bo= th are greater than 0 on FreeBSD i386/amd64 but may not be so on other platfor= ms. > +- if ( shmdt( mem_ptr ) < 0 ) > ++ if ( shmdt( mem_ptr ) < (void *)0 ) shmdt(2) returns int, not a pointer. I don't think you need to touch this l= ine. > +- if ( (fd =3D fopen( path, "w" )) < 0 ) > ++ if ( (fd =3D fopen( path, "w" )) < (void *)0 ) fopen(3) returns NULL on failure, not a negative value. Maybe use "=3D=3D N= ULL" instead. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-216627-13-0Wmy8iWENv>