From owner-svn-ports-head@freebsd.org Fri Mar 2 06:46:11 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03B4AF2904A; Fri, 2 Mar 2018 06:46:11 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x22c.google.com (mail-pg0-x22c.google.com [IPv6:2607:f8b0:400e:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8798B7009F; Fri, 2 Mar 2018 06:46:10 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x22c.google.com with SMTP id r26so3388288pgv.13; Thu, 01 Mar 2018 22:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/f6eNdqPqg62sWLSSh8TaxluzpJ167T8TJkB9Nx7iMs=; b=M2nyeCqGqpKoaAgsRW15qsUp+wZ3S6SDFbdcjr0clSewDbZwFBu5xIzApIxTwwEgbb W/Z25z5071zlZvpaYTOrdXkwugL8L0s3dHaAF07Kw5sCWGWKrLoPMVFKJp3mJh77TkhW zsRmJeLDZSeuN/C06ta9N4qBkdtrF6CBhM8CMzhEQsaQT0w3+eknN1D04/KCdrrIqloG r2dedH1Wvq2RTQe4tOMWk3KDmDdO/woYiNzjN2SWqrGjPZj0QA+wcEzQluQHvs1jfWr9 fnsh845tqflDOuKronqUysQXAKeGzokqBtOxSSTOsMgvsbdOKGxVAqThUTKnPIBDkHI2 QmSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/f6eNdqPqg62sWLSSh8TaxluzpJ167T8TJkB9Nx7iMs=; b=qHdUGMhBHBYitY2uty/5C4FPkfhWZ0r6N+rOTulTe0QFmgLwYiF0TLlAfq8WhiqRL0 A9rNNnQ7DwH/NShMgBNOlNtYv1cQvlAyevknoBK3NDCU4JAHDJOAOpZwj6iZhoX/WKPE n8addsVS9O6sila6t/thM986zO9SeGkauSL4fmH+RFww7HgnxCM5TYV9na8ZwzdREacp C4gzEKki5RxZje5Rv2M80iAQAbyGIb6WZvYsx3YvxkTDLl7AX34Wfn5mHuH2+uJhKGwj MfgHN2YwPPVXoBYQZhYXUSEoaW7vwmTd1uhZ0UbeepH6uA4mbFWgjpAm/6yT90OUfR7L +VLQ== X-Gm-Message-State: APf1xPD4xX5aoUgTQ8Yymc7j/+F0V27p4NpWKwhFKJo9o9h6qQNo1JY2 ucUcPGzrA5KBJYTy6qP58/YDydK1 X-Google-Smtp-Source: AG47ELsWb9gfIR0vZAS8Aee/Pat75SdMoxnkTwXY4flzMHYmS5fMBj3IdgceJXnnWH1UFmFneL0GjA== X-Received: by 10.99.125.69 with SMTP id m5mr3692748pgn.77.1519973169134; Thu, 01 Mar 2018 22:46:09 -0800 (PST) Received: from [192.168.1.100] (152.94.214.218.sta.wbroadband.net.au. [218.214.94.152]) by smtp.gmail.com with ESMTPSA id 14sm12789825pfi.132.2018.03.01.22.46.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 22:46:08 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r463373 - head/lang/python27 To: Antoine Brodin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python , Sunpoet Po-Chuan Hsieh References: <201803020631.w226Vl0q082202@repo.freebsd.org> From: Kubilay Kocak Message-ID: Date: Fri, 2 Mar 2018 17:46:04 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201803020631.w226Vl0q082202@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 06:46:11 -0000 On 3/2/18 5:31 PM, Antoine Brodin wrote: > Author: antoine > Date: Fri Mar 2 06:31:47 2018 > New Revision: 463373 > URL: https://svnweb.freebsd.org/changeset/ports/463373 > > Log: > Revert r463321, it breaks lang/python27 on at least vanilla FreeBSD 10.x Please also revert r462630 as well (referencing: PR: 226135). It was the original regression that prompted this commit. I'll investigate the new readline regression in the meantime. > Reported by: pkg-fallout > With hat: portmgr > > Modified: > head/lang/python27/Makefile > > Modified: head/lang/python27/Makefile > ============================================================================== > --- head/lang/python27/Makefile Fri Mar 2 06:20:55 2018 (r463372) > +++ head/lang/python27/Makefile Fri Mar 2 06:31:47 2018 (r463373) > @@ -14,21 +14,12 @@ COMMENT= Interpreted object-oriented programming langu > > LICENSE= PSFL > > -# lang/python* ports use CPPFLAGS over CFLAGS due to multiple complex > -# *FLAGS and include ordering bugs/issues in the Python build, that cause > -# modules such as elementtree and pyexpat to fail to build, among other > -# difficult to isolate issues. Do not add to or modify global variables > -# unless the implications and pitfalls are completely understood. > -# See: https://bugs.python.org/issue6299#msg210189 > - > USES= cpe ncurses pathfix pkgconfig readline:port shebangfix ssl tar:xz > PATHFIX_MAKEFILEIN= Makefile.pre.in > USE_LDCONFIG= yes > +CFLAGS+= -I${OPENSSLINC} > GNU_CONFIGURE= yes > - > -CPPFLAGS+= -I${OPENSSLINC} > -LDFLAGS+= -L${OPENSSLLIB} > - > +LIBS+= -L${OPENSSLLIB} > python_CMD= ${PREFIX}/bin/python${PYTHON_PORTVERSION:R} > SHEBANG_FILES= Lib/lib2to3/pgen2/*.py Lib/lib2to3/tests/*.py Lib/lib2to3/tests/data/*.py \ > Lib/idlelib/*.py Lib/encodings/*.py Lib/test/*.py Lib/UserString.py \ > @@ -69,6 +60,9 @@ IPV6_CONFIGURE_ENABLE= ipv6 > LIBFFI_CONFIGURE_ON= --with-system-ffi > LIBFFI_LIB_DEPENDS= libffi.so:devel/libffi > > +# Use CPPFLAGS over CFLAGS due to -I ordering, causing elementtree and pyexpat > +# to break in Python 2.7, or preprocessor complaints in Python >= 3.3 > +# Upstream Issue: https://bugs.python.org/issue6299 > NLS_USES= gettext > NLS_CPPFLAGS= -I${LOCALBASE}/include > NLS_LIBS= -L${LOCALBASE}/lib -lintl >