From owner-svn-src-all@FreeBSD.ORG Thu Jun 25 10:19:35 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19A19106564A; Thu, 25 Jun 2009 10:19:35 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 24B578FC1E; Thu, 25 Jun 2009 10:19:33 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 246787238; Thu, 25 Jun 2009 13:19:30 +0300 Message-ID: <4A434F2C.1020005@FreeBSD.org> Date: Thu, 25 Jun 2009 13:19:24 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.21 (X11/20090405) MIME-Version: 1.0 To: Rafal Jaworowski References: <200906241538.n5OFcHwp018860@svn.freebsd.org> In-Reply-To: <200906241538.n5OFcHwp018860@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194844 - in head/sys: conf dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 10:19:35 -0000 Rafal Jaworowski wrote: > Author: raj > Date: Wed Jun 24 15:38:17 2009 > New Revision: 194844 > URL: http://svn.freebsd.org/changeset/base/194844 > > Log: > Move non-PCI prototypes from ata-pci.h -> ata-all.h. > > This removes unnecessary PCI #includes dependency for systems with ATA > controllers living at non-PCI buses. > > Submitted by: Piotr Ziecik > Obtained from: Semihalf > > Modified: head/sys/conf/files > ============================================================================== > --- head/sys/conf/files Wed Jun 24 15:33:33 2009 (r194843) > +++ head/sys/conf/files Wed Jun 24 15:38:17 2009 (r194844) > @@ -491,12 +491,12 @@ dev/ata/ata_if.m optional ata | atacore > dev/ata/ata-all.c optional ata | atacore > dev/ata/ata-lowlevel.c optional ata | atacore > dev/ata/ata-queue.c optional ata | atacore > +dev/ata/ata-dma.c optional ata | atadma > +dev/ata/ata-sata.c optional ata | atasata What is atadma and atasata here, kernel options? What for are they needed? You will not be able to build most of drivers without them, while enabling them for others will not give you any benefit, just bigger code size. I think dependency must be reviewed there. -- Alexander Motin