From owner-freebsd-bugs Mon May 22 14: 0: 8 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 1A80D37BE1C for ; Mon, 22 May 2000 14:00:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id OAA96654; Mon, 22 May 2000 14:00:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Mon, 22 May 2000 14:00:02 -0700 (PDT) Message-Id: <200005222100.OAA96654@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: David Greenman Subject: Re: kern/18756: [PATCH] fxp device causes lockups after suspend/resume Reply-To: David Greenman Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/18756; it has been noted by GNATS. From: David Greenman To: mike ryan Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: kern/18756: [PATCH] fxp device causes lockups after suspend/resume Date: Mon, 22 May 2000 13:38:30 -0700 > >+ /* don't try to service interrupts when the interface isn't running */ >+ if ((ifp->if_flags & IFF_RUNNING) == 0) { >+ return; >+ } >+ > while ((statack = CSR_READ_1(sc, FXP_CSR_SCB_STATACK)) != 0) { This could be a problem. If an interrupt occurs, it must be acknowledged otherwise you'll be stuck in an infinit loop - PCI interrupts are level sensitive and must be cleared in the ISR. -DG David Greenman Co-founder, The FreeBSD Project - http://www.freebsd.org Creator of high-performance Internet servers - http://www.terasolutions.com Pave the road of life with opportunities. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message