From owner-cvs-all Mon Sep 24 12:34:24 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11]) by hub.freebsd.org (Postfix) with ESMTP id B7AD537B41D; Mon, 24 Sep 2001 12:34:07 -0700 (PDT) Received: from laptop.baldwin.cx ([147.11.46.209]) by mail.wrs.com (8.9.3/8.9.1) with ESMTP id MAA02198; Mon, 24 Sep 2001 12:34:07 -0700 (PDT) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200109240323.f8O3Nmf69956@freefall.freebsd.org> Date: Mon, 24 Sep 2001 12:33:49 -0700 (PDT) From: John Baldwin To: "David E. O'Brien" Subject: RE: cvs commit: src/sys/alpha/conf GENERIC src/sys/i386/conf GEN Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 24-Sep-01 David E. O'Brien wrote: > obrien 2001/09/23 20:23:48 PDT > > Modified files: > sys/alpha/conf GENERIC > sys/i386/conf GENERIC > sys/ia64/conf GENERIC > sys/pc98/conf GENERIC > sys/sparc64/conf GENERIC > Log: > + Fix misplacement of `txp' > + Document our -CURRENT debugging bits 1) The comments wrap beyongd 80 cols which is not very aesthetic :) They also don't have a space after the # character. 2) INVARIANT_SUPPORT does not enable any extra checks, it just provides support code that sanity checks may call (such as the _mtx_assert() function that backs mtx_assert()). 3) WITNESS is not mutex checks, it is checks for locks in general. It's true that lockmgr doesn't yet call witness, but that might be done in the future, and sx locks already use WITNESS as well. 4) Witness does not detect deadlocks. I've thought about adding a check to priority_propagation() to detect some deadlocks but haven't done that yet. All Witness does is maintain a tree of lock order relationships and report violations of those relationships which could potentially lead to a deadlock. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message