From owner-freebsd-current@FreeBSD.ORG  Tue Mar 15 06:25:53 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EE7D016A4CF
	for <freebsd-current@freebsd.org>;
	Tue, 15 Mar 2005 06:25:53 +0000 (GMT)
Received: from rosebud.otenet.gr (rosebud.otenet.gr [195.170.0.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E634643D39
	for <freebsd-current@freebsd.org>;
	Tue, 15 Mar 2005 06:25:52 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: from gothmog.gr (patr530-b168.otenet.gr [212.205.244.176])
	j2F6PRhC002497;	Tue, 15 Mar 2005 08:25:28 +0200
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.3/8.13.3) with ESMTP id j2F6Pm2a042849;
	Tue, 15 Mar 2005 08:25:48 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.3/8.13.3/Submit) id j2F6PmW1042848;
	Tue, 15 Mar 2005 08:25:48 +0200 (EET)
	(envelope-from keramida@ceid.upatras.gr)
Date: Tue, 15 Mar 2005 08:25:48 +0200
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Jose M Rodriguez <josemi@freebsd.jazztel.es>
Message-ID: <20050315062548.GA42826@gothmog.gr>
References: <200503142306.54642.freebsd@redesjm.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503142306.54642.freebsd@redesjm.local>
X-Mailman-Approved-At: Tue, 15 Mar 2005 13:07:25 +0000
cc: freebsd-current@freebsd.org
Subject: Re: rcNG changes/aditions
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2005 06:25:54 -0000

On 2005-03-14 23:06, Jose M Rodriguez <josemi@freebsd.jazztel.es> wrote:
> update to PR conf/75137 (sound modules): I rework this adding support
> for preloaded modules to /etc/rc.subr

> +#
>  # run_rc_command argument
[...]
> +					# try to load ${name}_modules
> +					#
> +			eval "_modules=\$${name}_modules"
> +			if [ -n "${_modules}" ]; then
> +				debug "run_rc_command: kldload ${_modules}."
> +				eval "preload_modules ${_modules}"
> +				_return=$?
> +				[ $_return -ne 0 ] && [ -z "$rc_force" ] &&
> +				    return 1
> +			fi

What happens if some of the modules are already loaded and rc_force is
not set?  It looks like this may cause run_rc_command() to fail, even
though the modules are loaded and a subsequent run of the rc command
would succeed if attempted.

- Giorgos