From owner-svn-src-all@freebsd.org Thu May 12 22:50:36 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E0F7B3966D; Thu, 12 May 2016 22:50:36 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48ACA1956; Thu, 12 May 2016 22:50:35 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f66.google.com with SMTP id d139so14410801oig.1; Thu, 12 May 2016 15:50:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=auINrjrholPZwWdcq0eouPL4kYWiPX43m/7DwdlVUsg=; b=SrHBgIxbPgjRiZRumK7zNivphGoXtXmlQCpAzOw1PyLVFFwG9IWZdwXh8sjCI2S72d 6kULG2Jn+Mw79d6b3UethtzKNdokrZhJh1OyPUH9jkDcjOSc6/py5Gi5ujFr0O/1QyCK LdgA6Fdmfd4rlZAaatyAbbtksMcuToB6hp+ajsm8uwXwxPhOiqsTcRpflS7nSiczsTex 54sVVVMpxsIhHx30I7gM7+eqg13RCAEkjFaEYf0YmMxv3CA8jJvKlNVme+4aF0m3iJdX w4xuPZtvElq1yyoGbIWDfl/u6/erhiGT0uhXjBm1c6yfIlIZwJTZbM9zYwfTgVHyExCE dbCQ== X-Gm-Message-State: AOPr4FVu2ewQJfa72uVYGZAXTaqOK9Bzq6Y/nQJFzJWj3dAWsNo5mLe3UARC5bE7WKgsuQ== X-Received: by 10.157.18.143 with SMTP id g15mr6478331otg.125.1463092389504; Thu, 12 May 2016 15:33:09 -0700 (PDT) Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com. [209.85.218.47]) by smtp.gmail.com with ESMTPSA id mz4sm4470271obb.20.2016.05.12.15.33.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 May 2016 15:33:09 -0700 (PDT) Received: by mail-oi0-f47.google.com with SMTP id x19so143381304oix.2; Thu, 12 May 2016 15:33:09 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.102.222 with SMTP id m91mr6967091oik.79.1463092388908; Thu, 12 May 2016 15:33:08 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.19.20 with HTTP; Thu, 12 May 2016 15:33:08 -0700 (PDT) In-Reply-To: References: <201605111438.u4BEcSIX092807@repo.freebsd.org> Date: Thu, 12 May 2016 15:33:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r299456 - in head: include lib/libc/stdio From: Conrad Meyer To: Antoine Brodin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 22:50:36 -0000 On Thu, May 12, 2016 at 12:49 PM, Antoine Brodin wrote: > On Wed, May 11, 2016 at 4:38 PM, Conrad E. Meyer wrote: >> Author: cem >> Date: Wed May 11 14:38:27 2016 >> New Revision: 299456 >> URL: https://svnweb.freebsd.org/changeset/base/299456 >> >> Log: >> libc: Add fopencookie(3) wrapper around funopen(3) >> >> Reviewed by: jhb, oshogbo >> Sponsored by: EMC / Isilon Storage Division >> Differential Revision: https://reviews.freebsd.org/D6282 > > Please revert this and request a ports exp-run as this breaks lots of > important ports. The number of failed ports is actually pretty small (less than 11). I've identified a couple different kinds of issue and implemented fixes for them. 1. libc doesn't actually export the fopencookie() function, because it was missing from Symbols.map (base issue). This is rectified in 299572 and I've personally test-built php56 successfully with that change. 2. Some ports assume that off64_t's presence in stdio.h implies it is more widely available (port issue). Or that it implies __off64_t exists. Examples: devel/rudiments, devel/zziplib. To that end, I've made off64_t and __off64_t as widely available as off_t and __off_t in r299571. I've test-built both of these and both succeed after these changes. 3. Finally, Clang (?)sometimes rejects that particular style of function typedef (base issue). Additionally, sometimes size_t isn't defined. For example, lang/pypy. r299574 fixes that issue. I've personally test-built pypy (well, it's still compiling, but it's past that initial platform detection failure now). Are there any other important ports you think this change impacted? Several other failures are not related to this change (Lynx, Xterm, ncurses, cdialog). So, other than assuming php70 and php55 will be fixed by the same change as php56, I don't think there are any failures unaccounted for that I haven't test-built successfully at this point. Do you still want a revert, or any further test builds? Or is that fine? Best, Conrad