From owner-freebsd-hackers@freebsd.org Tue Sep 3 06:12:28 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 078D3CD062 for ; Tue, 3 Sep 2019 06:12:28 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46MxSV6257z3Nhx for ; Tue, 3 Sep 2019 06:12:26 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id A679C1581 for ; Tue, 3 Sep 2019 02:12:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 03 Sep 2019 02:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=f tpZZvLLGw4PSS8eFr8JT73dWuejESoTvVnC9o+d2ow=; b=XtB1R/13JvvHNfM5b i26NLyOoBQ3qNCYvsPqC7/ODmYQrZqXKsL41GMdbMsFjzjldQ4avFqapui2b3WVp l2BJrncbVBMZx8XT81t+ruW2VAs6PsquEIm4bNECXMyG6EngSomUWyIJYU8QSHHT kzLCVT0d7ifV4CuYKYZ/VqusjwHpE/mdWozXy1LceX4rxfFVa1Grl6rDD+Iuq2Y2 EI4HCgvAjz0jhUPN4kl8R7tyth3XdIN8Q7sCjmkbWIYWXZt4hu6mmnVki/93qlpw Bqa6qcyt1ygRsUDonK6Dwwhr1JAaC6dY8dxhIXnSs4gH3TTmjKChwsntC6JHkeQj QbpGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ftpZZvLLGw4PSS8eFr8JT73dWuejESoTvVnC9o+d2 ow=; b=BDjqc/ZqHUWY47r+/i//fs2XAvJBt5+ix+tfHEuYedhRwJUN5k+/SmBvR Ds6qfR8Ss22O2I5ePokLtth9kIVEY8KDdqvWPt8cRoydD1oC9QYrkjBbbJGmAt+v Q9P3TGOG2Y2V7N8vRDzjoKHLidz8zr8n0Dt9tn1m05nz9fzEC4u270+XU9/a2z1N dAP8+scBWU+9XcXYZOluXnTI3ZLHO6/fBHlgzpwdrj+6AXIyCdKBrkPJTrR8Cc0q kezq3ZPOgVJnIsjC9XU+LNfCKQWRVMNofP/z7ihlwWW8zNAATrvCc6ka7cIou25m sxBklJndcnEcnDG9jPcREBjNnCVsg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejuddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhr ihcurfgrnhhkohhvuceohihurhhiphhvseihuhhrihhpvhdrnhgvtheqnecuffhomhgrih hnpehfrhgvvggsshgurdhorhhgnecukfhppeduleehrddvtdeirddukeefrdduieejnecu rfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihhpvheshihurhhiphhvrdhnvghtnecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [192.168.1.2] (unknown [195.206.183.167]) by mail.messagingengine.com (Postfix) with ESMTPA id CB25A80062 for ; Tue, 3 Sep 2019 02:12:24 -0400 (EDT) Subject: Re: Looking for review / testing for nvme suspend / resume support To: FreeBSD Hackers References: From: Yuri Pankov Message-ID: <41727448-9b0d-69dd-00f3-de30d9d5902b@yuripv.net> Date: Tue, 3 Sep 2019 09:12:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46MxSV6257z3Nhx X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.net header.s=fm1 header.b=XtB1R/13; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=BDjqc/Zq; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.net designates 66.111.4.230 as permitted sender) smtp.mailfrom=yuripv@yuripv.net X-Spamd-Result: default: False [-7.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[yuripv.net:s=fm1,messagingengine.com:s=fm3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.230]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[yuripv.net]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; IP_SCORE(-3.49)[ip: (-9.87), ipnet: 66.111.4.0/24(-4.84), asn: 11403(-2.68), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[230.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 06:12:28 -0000 Warner Losh wrote: > I've posted a review: https://reviews.freebsd.org/D21493 for NVMe suspend / > resume support. This avoids issues where we come out of suspend and need to > wait 30s for there to be a timeout and a reset of the device. It does so by > completely shutting down the card before we suspend, and then assume it was > in an unknown state when we come back up. > > Please leave comments about successful (or unsuccessful) tests and/or ways > to improve the code. Not seeing any issues with "SAMSUNG MZVLB512HAJQ", both suspend/resume were almost instant, no messages from nvme/nvd logged, no errors from zpool status/scrub.