From owner-freebsd-net Thu Feb 21 13:44:28 2002 Delivered-To: freebsd-net@freebsd.org Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 14F3737B416 for ; Thu, 21 Feb 2002 13:44:24 -0800 (PST) Received: (from rizzo@localhost) by iguana.icir.org (8.11.6/8.11.3) id g1LLi7952762; Thu, 21 Feb 2002 13:44:07 -0800 (PST) (envelope-from rizzo) Date: Thu, 21 Feb 2002 13:44:07 -0800 From: Luigi Rizzo To: Mike Silbersack Cc: Brian White , freebsd-net@FreeBSD.ORG Subject: Re: SACK (and older TCP stack) availability? Message-ID: <20020221134407.B52538@iguana.icir.org> References: <20020221014912.M20299-100000@patrocles.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020221014912.M20299-100000@patrocles.silby.com> User-Agent: Mutt/1.3.23i Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Thu, Feb 21, 2002 at 01:54:20AM +0000, Mike Silbersack wrote: > > > I tracked a thread from Aug 2001 in which Harkirat Singh announced his > > SACK implementation. But, this thread seems to have ended prematurely and > > grep'ing for SACK in current does not turn up anything interesting. What > > is it's status? Was the 4.3 SACK diff stable? > > I never got time to test it, nor did any other committer I'm aware of. > If someone were to do some good testing of the patch and post the results, > that would be highly helpful in getting it on the road to being committed. > Unadvocated patches ususally don't get committed. I actually looked at the patches, and by visual inspection, they broke the flow for standard TCP connections when SACK was disabled. This was also verified with TBIT. So even if the SACK implementation was correct (which I haven't checked in detail) they are a no-go unless someone puts significant work on them. cheers luigi ----------------------------------+----------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . ICSI (on leave from Univ. di Pisa) http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 Phone: (510) 666 2927 ----------------------------------+----------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message