Date: Sun, 01 Apr 2012 14:02:15 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: FreeBSD Ports Mailing List <ports@freebsd.org> Subject: Preferred way of applying OSVERSION-dependend patches Message-ID: <4F7827A7.3030804@yandex.ru>
next in thread | raw e-mail | index | archive | help
Good day!
What is a preferred way of doing subj?
1. Add an extra-patch-* to files/ subdirectory and apply it depending
of checks in Makefile (.if ${OSVERSION}).
2. Add an patch-* to files subdirectory that applies unconditionally
and that checking for __FreeBSD_version in app code itself.
The second one will guarantee that the patch still applies cleanly on
port versions update, but it will make it more hard to find conditional
checks for obsoleted FreeBSD versions (because most people, I believe,
only looking to Makefile for things like this).
Thanks.
--
Regards,
Ruslan
Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F7827A7.3030804>