From owner-cvs-all Mon Mar 18 0:19:32 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id A354137B405; Mon, 18 Mar 2002 00:19:25 -0800 (PST) Received: from blossom.cjclark.org ([12.234.91.48]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020318081924.DAFE2626.rwcrmhc51.attbi.com@blossom.cjclark.org>; Mon, 18 Mar 2002 08:19:24 +0000 Received: (from cjc@localhost) by blossom.cjclark.org (8.11.6/8.11.6) id g2I8JMM58490; Mon, 18 Mar 2002 00:19:22 -0800 (PST) (envelope-from cjc) Date: Mon, 18 Mar 2002 00:19:22 -0800 From: "Crist J. Clark" To: Shin-ichi YOSHIMOTO Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318001922.Z29705@blossom.cjclark.org> Reply-To: cjclark@alum.mit.edu References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318161250.1c35600c.yosimoto@waishi.jp> <20020318170348.671ec4b5.yosimoto@waishi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020318170348.671ec4b5.yosimoto@waishi.jp>; from yosimoto@waishi.jp on Mon, Mar 18, 2002 at 05:03:48PM +0900 X-URL: http://people.freebsd.org/~cjc/ Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 18, 2002 at 05:03:48PM +0900, Shin-ichi YOSHIMOTO wrote: > Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h, > On 18 Mar 2002 08:29:10 +0100, Dag-Erling Smorgrav wrote: > > In vipw, IIRC; check the .PATH in usr.bin/chpass/Makefile. > > really ? I can't find in vipw. > > > ls /usr/src/usr.sbin/vipw/ > CVS/ Makefile pw_util.c pw_util.h vipw.8 vipw.c > > I found in ... > > > find /usr/src -name "pw_scan.h" -print > /usr/src/lib/libc/gen/pw_scan.h chpass(8) is very, very naughty and uses __pw_scan(). It does use the one in libc. From it's Makefile, CFLAGS+=-I${.CURDIR}/../../usr.sbin/pwd_mkdb -I${.CURDIR}/../../usr.sbin/vipw -I${.CURDIR}/../../lib/libc/gen Don't blame me. It was already used in chpass.c and edit.c. This isn't an issue in -STABLE, where pw_scan() is exposed to the world properly in libc. chpass(8) is _old_ code (note I needed to add the $FreeBSD$ to pw_copy.h, pathnames.h isn't actually used by anything) and really could use a clean up. I have already gone through a round of clean ups locally, but want to let this commit settle, since it actually has functional differences, before I go making style changes and fixes. -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message