Date: Mon, 18 Mar 2002 00:19:22 -0800 From: "Crist J. Clark" <crist.clark@attbi.com> To: Shin-ichi YOSHIMOTO <yosimoto@waishi.jp> Cc: Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318001922.Z29705@blossom.cjclark.org> In-Reply-To: <20020318170348.671ec4b5.yosimoto@waishi.jp>; from yosimoto@waishi.jp on Mon, Mar 18, 2002 at 05:03:48PM %2B0900 References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318161250.1c35600c.yosimoto@waishi.jp> <xzpit7upc55.fsf@flood.ping.uio.no> <20020318170348.671ec4b5.yosimoto@waishi.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 18, 2002 at 05:03:48PM +0900, Shin-ichi YOSHIMOTO wrote:
> Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h,
> On 18 Mar 2002 08:29:10 +0100, Dag-Erling Smorgrav wrote:
> > In vipw, IIRC; check the .PATH in usr.bin/chpass/Makefile.
>
> really ? I can't find in vipw.
>
> > ls /usr/src/usr.sbin/vipw/
> CVS/ Makefile pw_util.c pw_util.h vipw.8 vipw.c
>
> I found in ...
>
> > find /usr/src -name "pw_scan.h" -print
> /usr/src/lib/libc/gen/pw_scan.h
chpass(8) is very, very naughty and uses __pw_scan(). It does use the
one in libc. From it's Makefile,
CFLAGS+=-I${.CURDIR}/../../usr.sbin/pwd_mkdb -I${.CURDIR}/../../usr.sbin/vipw -I${.CURDIR}/../../lib/libc/gen
Don't blame me. It was already used in chpass.c and edit.c.
This isn't an issue in -STABLE, where pw_scan() is exposed to the
world properly in libc.
chpass(8) is _old_ code (note I needed to add the $FreeBSD$ to
pw_copy.h, pathnames.h isn't actually used by anything) and really
could use a clean up. I have already gone through a round of clean ups
locally, but want to let this commit settle, since it actually has
functional differences, before I go making style changes and fixes.
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020318001922.Z29705>