From owner-svn-src-all@freebsd.org Sun Sep 4 20:57:50 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 472ADB7158A; Sun, 4 Sep 2016 20:57:50 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 187C3306; Sun, 4 Sep 2016 20:57:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f43.google.com with SMTP id e124so120756962ith.0; Sun, 04 Sep 2016 13:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=VlbMcH6/qRQs4HRvc5cqsVmPKFT7TT7NQHgBW6WARus=; b=fENFzziXI6I206jiqjVfTGyfiM+mBfDW5lFsS+6NTNCUPRsEmJLF9sjQ1XbepUyAa1 qJob4KDjuIyW86Gj6A1ct4bsBKpGXnPURF8IO54eZ4PV5ApF+jhYIVvezftiTKXdCqqj t6VniwwUVcWLenWPkwWXzM9NIoKfl8dBZGUBoAY9qRuMsA+9afTn9IYJf2WmExuqR+K+ COTOMp9SEM77mKO/Kzj5wGl6vSmGPK8epF/FZw8IjMvjaDNyKuxa8dwxnXa22Ps9ziX/ ACSJf7F4xtmW1nKL59i9LQq60LJsCYGd00r4o5TNBdMEKADWFL0Yul0Gac70m5KCPbvi KCrw== X-Gm-Message-State: AE9vXwPfRuxR/YlXrp2urCMcKqooV9QQj8U+GEdHdPGa4wqnHzW7ZNb9rkmeQ0PaGI60xw== X-Received: by 10.36.147.2 with SMTP id y2mr19477719itd.67.1473022663097; Sun, 04 Sep 2016 13:57:43 -0700 (PDT) Received: from mail-it0-f49.google.com (mail-it0-f49.google.com. [209.85.214.49]) by smtp.gmail.com with ESMTPSA id 140sm8227121itl.4.2016.09.04.13.57.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Sep 2016 13:57:43 -0700 (PDT) Received: by mail-it0-f49.google.com with SMTP id c198so121129080ith.1; Sun, 04 Sep 2016 13:57:42 -0700 (PDT) X-Received: by 10.36.212.132 with SMTP id x126mr19712393itg.34.1473022662721; Sun, 04 Sep 2016 13:57:42 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sun, 4 Sep 2016 13:57:42 -0700 (PDT) In-Reply-To: <000B5E66-D804-4317-9957-8BDEDBD6B7F6@FreeBSD.org> References: <201609041755.u84HtMa5060050@repo.freebsd.org> <000B5E66-D804-4317-9957-8BDEDBD6B7F6@FreeBSD.org> From: Conrad Meyer Date: Sun, 4 Sep 2016 13:57:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r305392 - head/sys/conf To: Dimitry Andric Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 20:57:50 -0000 Hm, the GCC 5.3 manual page mentions at least -Wshift-count-negative, -Wshift-count-overflow, and -Wcast-qual. Best, Conrad On Sun, Sep 4, 2016 at 1:36 PM, Dimitry Andric wrote: > Not in this particular case, as the section is exclusively meant for > clang. Most of these warning options are completely different from > gcc's. The gcc related section is just below this part in kern.mk. > > -Dimitry > >> On 04 Sep 2016, at 22:03, Conrad Meyer wrote: >> >> Assuming we'd like to enable building with both compilers for now, >> isn't it better to use a form both accept? >> >> Best, >> Conrad >> >> On Sun, Sep 4, 2016 at 12:31 PM, Dimitry Andric wrote: >>> On 04 Sep 2016, at 20:57, Conrad Meyer wrote: >>>> >>>> On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric wrote: >>>>> Author: dim >>>>> Date: Sun Sep 4 17:55:22 2016 >>>>> New Revision: 305392 >>>>> URL: https://svnweb.freebsd.org/changeset/base/305392 >>>>> >>>>> Log: >>>>> For kernel builds, instead of suppressing certain clang warnings, make >>>>> them non-fatal, so there is some incentive to fix them eventually. >>>>> >>>>> Modified: >>>>> head/sys/conf/kern.mk >>>>> >>>>> Modified: head/sys/conf/kern.mk >>>>> ============================================================================== >>>>> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 (r305391) >>>>> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 (r305392) >>>>> @@ -17,13 +17,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wn >>>>> # kernel where fixing them is more trouble than it is worth, or where there is >>>>> # a false positive. >>>>> .if ${COMPILER_TYPE} == "clang" >>>>> -NO_WCONSTANT_CONVERSION= -Wno-constant-conversion >>>>> -NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative >>>>> -NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow >>>>> -NO_WSELF_ASSIGN= -Wno-self-assign >>>>> -NO_WUNNEEDED_INTERNAL_DECL= -Wno-unneeded-internal-declaration >>>>> +NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion >>>>> +NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative >>>>> +NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow >>>>> +NO_WSELF_ASSIGN= -Wno-error-self-assign >>>>> +NO_WUNNEEDED_INTERNAL_DECL= -Wno-error-unneeded-internal-declaration >>>>> NO_WSOMETIMES_UNINITIALIZED= -Wno-error-sometimes-uninitialized >>>>> -NO_WCAST_QUAL= -Wno-cast-qual >>>>> +NO_WCAST_QUAL= -Wno-error-cast-qual >>>> >>>> I like goal of the change. Shouldn't these be -Wno-error=cast-qual, >>>> etc., though? >>> >>> That's how gcc spells them. Clang accepts both forms, there is no >>> functional difference. >>> >>> -Dimitry >>> >