From owner-svn-src-all@FreeBSD.ORG  Sat Oct 27 08:10:38 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BC31CACF;
 Sat, 27 Oct 2012 08:10:38 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 75EA28FC0A;
 Sat, 27 Oct 2012 08:10:37 +0000 (UTC)
Received: by mail-pa0-f54.google.com with SMTP id bi1so2545966pad.13
 for <multiple recipients>; Sat, 27 Oct 2012 01:10:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
 :content-transfer-encoding;
 bh=I/jMdrjmjZUZLUw/sXnF5QZvv3KojB33+sv+vzmT3s0=;
 b=Tgom5rrG2MeFgIzXARELtPiV5cXJdxInKZBcmfdLqWCJBpBAfo8q8qHSNf0YAOtA17
 qTYcZvBceoOpIHkJQ9NgFPtX06Aturi2vIKWOVUOrNHoL97WsAq4Jy01cug9IHnfAbqd
 GiyJ1VukHrOvKh3wNIHJlOvIjUr+b4MBHlmuad+12E9Awd912b2Ti2Cn5KkGoouq42+2
 qbF/njixxhdIByCvk6VD8kF/K2ZsHyPL2Kq/ADhLIUj7eMZokEMCx5dYJMikdsxhbjfo
 VKPWUadv99YdcCHN4Ol+IJnJBirIwIEq9641tzrx4yipHBXStyOxNZUoLYPlsEmrHZAh
 5EBQ==
MIME-Version: 1.0
Received: by 10.68.229.201 with SMTP id ss9mr76230524pbc.80.1351325436904;
 Sat, 27 Oct 2012 01:10:36 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.68.146.233 with HTTP; Sat, 27 Oct 2012 01:10:36 -0700 (PDT)
In-Reply-To: <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
References: <201210161337.q9GDbtr8049924@svn.freebsd.org>
 <CAJ-Vmon8BxdbTUsOXF7kCOqO3=GuKXaHFqOqGHoGgmGV2=+6aw@mail.gmail.com>
 <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
Date: Sat, 27 Oct 2012 01:10:36 -0700
X-Google-Sender-Auth: F5mywVWxj09anbj6TqAaTinmWiA
Message-ID: <CAJ-Vmo=-X4h22XBptqDJKz8W9ZbCp_ymfUZdkvgxCObB9jnPsg@mail.gmail.com>
Subject: Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211
 sys/netpfil/ipfw sys/netpfil/pf sys/sys
From: Adrian Chadd <adrian@freebsd.org>
To: Rui Paulo <rpaulo@felyko.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2012 08:10:38 -0000

On 26 October 2012 21:16, Rui Paulo <rpaulo@felyko.com> wrote:
> I second Adrian's comments and I would like to add that you must NOT comm=
it something like this, breaking the ABI, when you discussed this *ONE YEAR=
* ago with only two people (one of them is not very active in the networkin=
g stack). This is against all reasonable software development practices.

It's fine now; I've fixed the net80211 case.

Please, just next time give us all a bit more of a heads up before you
drop this stuff in. You won't hear me saying "hell no" - I'll be
saying "ok, how do I teach my code to still work on -9." Which is what
I ended up doing.

Your work is sorely needed, don't get me wrong. :-) I'm glad you're doing i=
t.

Thanks,



Adrian