From owner-freebsd-arch@FreeBSD.ORG  Thu Mar 25 13:41:20 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8599E106566B;
	Thu, 25 Mar 2010 13:41:20 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 43DA18FC19;
	Thu, 25 Mar 2010 13:41:20 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o2PDbXS3080127;
	Thu, 25 Mar 2010 07:37:33 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Thu, 25 Mar 2010 07:37:36 -0600 (MDT)
Message-Id: <20100325.073736.635700942514937954.imp@bsdimp.com>
To: jhb@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201003250749.57994.jhb@freebsd.org>
References: <201003241132.29588.jhb@freebsd.org>
	<20100325105615.10186jr08a5oj00s@webmail.leidinger.net>
	<201003250749.57994.jhb@freebsd.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Alexander@leidinger.net, rwatson@FreeBSD.org, freebsd-arch@FreeBSD.org
Subject: Re: CTF patch for testing/review
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Mar 2010 13:41:20 -0000

In message: <201003250749.57994.jhb@freebsd.org>
            John Baldwin <jhb@freebsd.org> writes:
: On Thursday 25 March 2010 5:56:15 am Alexander Leidinger wrote:
: > Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 11:32:29 
: -0400):
: > 
: > > On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
: > >> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 10:05:55
: > > -0400):
: > >>
: > >> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
: > >>
: > >> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
: > >> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
: > >> >> that all makeoptions do not propagate to module builds.
: > >> >>
: > >> >> Any ideas?
: > >> >
: > >> > Hmmmm.  That's odd because 'DEBUG=-g' does work.  Ah, I think you 
: should
: > >> > patch kern.post.mk to propogate WITH_CTF to modules.  This is how it 
: works
: > >> > for DEBUG now:
: > >> >
: > >> > .if defined(DEBUG)
: > >> > MKMODULESENV+=  DEBUG_FLAGS="${DEBUG}"
: > >> > .endif
: > >>
: > >> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk
: > >> instead of kernl.post.mk)?
: > >
: > > No, I think it is fine to treat it the same as DEBUG.
: > 
: > DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have  
: > WITH_CTF handling in kern.post.mk, and thus it can not be overriden.  
: > There are some MKMODULESENV things in post.mk already.
: 
: Ok.
: 
: > On a related note, the LD_CTF_FLAGS thing does not seem to work for  
: > modules. Reading the man page of ld tells that -g is a noop (the  
: > switch is ignored). Thus I would prefer to remove the setting of -g  
: > for ld. Any objections?
: 
: Ok.

In general, I think this is OK.  I'd like to see the revised patch
before it is committed.

Warner