From owner-freebsd-arch@FreeBSD.ORG Fri Sep 3 07:56:16 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EC7F1065722; Fri, 3 Sep 2010 07:56:16 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E8E278FC0C; Fri, 3 Sep 2010 07:56:14 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA11706; Fri, 03 Sep 2010 10:43:37 +0300 (EEST) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1OrQvw-000732-RF; Fri, 03 Sep 2010 10:43:36 +0300 Message-ID: <4C80A728.6090002@freebsd.org> Date: Fri, 03 Sep 2010 10:43:36 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.8) Gecko/20100822 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: freebsd-arch@freebsd.org X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: newbus: type (max value) for device order X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2010 07:56:16 -0000 device_add_child_ordered() takes order as a parameter of int type. struct device stores it as u_char. This can be confusing, can't it? In fact, up to r203776 we used to use order value of 100000 in acpi.c (which effectively was 160 according to my calculations). Not sure what I want to suggest, perhaps defining DEVICE_MAX_ORDER or something. Or changing the type in struct device to int. -- Andriy Gapon