From owner-svn-src-all@freebsd.org Tue Jul 5 03:15:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37EA1B92D05 for ; Tue, 5 Jul 2016 03:15:52 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0773526BE for ; Tue, 5 Jul 2016 03:15:51 +0000 (UTC) (envelope-from julio@meroh.net) Received: by mail-qk0-x230.google.com with SMTP id t127so278537019qkf.1 for ; Mon, 04 Jul 2016 20:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meroh.net; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1BVzn+QsuN2o+B7qx1xQGQqqseSYEzfmls9KPZi1jyo=; b=cA5qALIwKEC4+eQsZsWl5ErOvmMizYSlw57hax/K5lFHLJp3hFUfExZzF2aIWWYyfS i5a4Pk4CkmeON1AGA5fri1Abde/KqEvnTPZ+Qe2XIvu++dsZJo5m7mAHYvutJN8DJGN9 h9alAzVos8g9vzomsNvMRI/ARElF/fuxHlVnHO7Xf/ej59AFFCjhshiCg0LSMSewKD3Y v9A0No3hAUaA3uRaaRb0hkoJcVb0gHbTLFZIF2HAGVY7kYD91cx0xsOOgk6yjH/F1wJs yZyqaiB/s0oVqCtU04K0oQlmCz6NmOuzucuYw8SC82O1sa+oDLILBvdErzv0JFay2EkC bV6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1BVzn+QsuN2o+B7qx1xQGQqqseSYEzfmls9KPZi1jyo=; b=KJvGJkxCKNtF/GaTmsufZlrczmtQQYA6iTYwnY1buVt8+t0GHpzmNHDPuC/KOXJ/kM NM4HYndJNK/eDsg7QHOzRDSFJ7MuJBC9CE+5Mg+eduhn9gOtxioaIpW0/LFGGZoZ45iT FkegwIGLz3W8Ezkp9gkrJw+bgIABkxGsA+vWKLigJ2Zk0RZHn9COutXYy9zJdi8vgf7Z RNeAWJXCHE44Q+7BBOkrSbjmfkSHRpzXLmHcXafpptX1TuqHh8p5DkwQMHpT3dE8a9fC 9FdPa+uZ4RcXJXTHlpHs1XHsAv9fOJ6eVes+qJlIfdgFd1ducMu0JF9PsFVkZDfcIzDn 6jaw== X-Gm-Message-State: ALyK8tKmaA3kCO3iwIlZv+FHYauvLPbz+RL1Pc0Z8UVB1hZGYFY6JaHXs/YHZdJz/v+81OO45ZVj8Edb3VIzjQ== X-Received: by 10.55.212.147 with SMTP id s19mr20208834qks.64.1467688550990; Mon, 04 Jul 2016 20:15:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.55.67 with HTTP; Mon, 4 Jul 2016 20:15:31 -0700 (PDT) X-Originating-IP: [2604:2000:c650:dc00:4cad:1729:89de:1059] In-Reply-To: <201605112339.u4BNdehd062987@repo.freebsd.org> References: <201605112339.u4BNdehd062987@repo.freebsd.org> From: Julio Merino Date: Mon, 4 Jul 2016 23:15:31 -0400 Message-ID: Subject: Re: svn commit: r299496 - head/contrib/atf/atf-c/detail To: "Conrad E. Meyer" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 03:15:52 -0000 On Wed, May 11, 2016 at 7:39 PM, Conrad E. Meyer wrote: > Author: cem > Date: Wed May 11 23:39:39 2016 > New Revision: 299496 > URL: https://svnweb.freebsd.org/changeset/base/299496 > > Log: > atf map: Fix double-free in low memory error path > > If atf_list_append(, X, ) fails, X is freed. Don't free it again. This fix seems bogus. I think the following is correct: https://github.com/jmmv/atf/commit/710d1cf96f3ab716e76b569714fd7303292d93b2 -- Julio Merino -- http://julio.meroh.net/