From owner-svn-src-all@FreeBSD.ORG Thu Jun 25 10:42:54 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FC5B106566C; Thu, 25 Jun 2009 10:42:54 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id F311A8FC22; Thu, 25 Jun 2009 10:42:53 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from [10.0.0.34] (cardhu.semihalf.com [213.17.239.108]) by smtp.semihalf.com (Postfix) with ESMTPSA id 97514C3BB6; Thu, 25 Jun 2009 12:41:27 +0200 (CEST) Message-Id: From: Rafal Jaworowski To: Alexander Motin In-Reply-To: <4A434F2C.1020005@FreeBSD.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 25 Jun 2009 12:42:52 +0200 References: <200906241538.n5OFcHwp018860@svn.freebsd.org> <4A434F2C.1020005@FreeBSD.org> X-Mailer: Apple Mail (2.935.3) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, =?ISO-8859-2?Q?Piotr_Zi=EAcik?= Subject: Re: svn commit: r194844 - in head/sys: conf dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 10:42:55 -0000 On 2009-06-25, at 12:19, Alexander Motin wrote: > Rafal Jaworowski wrote: >> Modified: head/sys/conf/files >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- head/sys/conf/files Wed Jun 24 15:33:33 2009 (r194843) >> +++ head/sys/conf/files Wed Jun 24 15:38:17 2009 (r194844) >> @@ -491,12 +491,12 @@ dev/ata/ata_if.m optional ata | atacore >> dev/ata/ata-all.c optional ata | atacore >> dev/ata/ata-lowlevel.c optional ata | atacore >> dev/ata/ata-queue.c optional ata | atacore >> +dev/ata/ata-dma.c optional ata | atadma >> +dev/ata/ata-sata.c optional ata | atasata > > What is atadma and atasata here, kernel options? What for are they > needed? You will not be able to build most of drivers without them, > while enabling them for others will not give you any benefit, just > bigger code size. I think dependency must be reviewed there. This was supposed to follow the fine grained kernel options route for various ata subsystems. Both ata-dma.c and ata-sata.c seem orthogonal to the rest of the ata framework (think ata controller without DMA, which is often seen in embedded). They could also be made mandatory under atacore, I have no problem with this approach too. Rafal