From owner-svn-src-all@freebsd.org  Sat Nov 14 17:26:36 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 676C8A2FD03;
 Sat, 14 Nov 2015 17:26:36 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249])
 by mx1.freebsd.org (Postfix) with ESMTP id DBA3817C1;
 Sat, 14 Nov 2015 17:26:35 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from bender.Home (bcdc67a8.skybroadband.com [188.220.103.168])
 by kif.fubar.geek.nz (Postfix) with ESMTPSA id 66C00D78E6;
 Sat, 14 Nov 2015 17:26:05 +0000 (UTC)
Date: Sat, 14 Nov 2015 17:26:04 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: Edward Tomasz Napierala <trasz@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r290821 - head/usr.sbin/ctld
Message-ID: <20151114172604.0b7bfbd5@bender.Home>
In-Reply-To: <56476DD6.5010805@FreeBSD.org>
References: <201511141606.tAEG61Rh062202@repo.freebsd.org>
 <20151114172030.7dfc24d0@bender.Home>
 <56476DD6.5010805@FreeBSD.org>
X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; amd64-portbld-freebsd10.1)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Nov 2015 17:26:36 -0000

On Sat, 14 Nov 2015 09:22:30 -0800
Bryan Drewery <bdrewery@FreeBSD.org> wrote:

> On 11/14/2015 9:20 AM, Andrew Turner wrote:
> > On Sat, 14 Nov 2015 16:06:01 +0000 (UTC)
> > Edward Tomasz Napierala <trasz@FreeBSD.org> wrote:
> >   
> >> Author: trasz
> >> Date: Sat Nov 14 16:06:01 2015
> >> New Revision: 290821
> >> URL: https://svnweb.freebsd.org/changeset/base/290821
> >>
> >> Log:
> >>   Don't try to avoid calling free(3) with NULL argument.  
> > 
> > Why? free(NULL) is documented to be a nop and is safe to rely on
> > this behaviour.
> >   
> 
> You read it backwards, see the change. It's doing what you want.

Yes, I should read the change more than briefly.

Andrew