From owner-freebsd-security  Thu Apr  5 17:38:27 2001
Delivered-To: freebsd-security@freebsd.org
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP id AA41137B496
	for <security@FreeBSD.ORG>; Thu,  5 Apr 2001 17:38:25 -0700 (PDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id UAA73318;
	Thu, 5 Apr 2001 20:38:02 -0400 (EDT)
	(envelope-from wollman)
Date: Thu, 5 Apr 2001 20:38:02 -0400 (EDT)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Message-Id: <200104060038.UAA73318@khavrinen.lcs.mit.edu>
To: Brian Somers <brian@Awfulhak.org>
Cc: security@FreeBSD.ORG
Subject: Re: ntpd patch 
In-Reply-To: <200104060033.f360XfP03505@hak.lan.Awfulhak.org>
References: <ache@nagual.pp.ru>
	<20010406035459.A6350@nagual.pp.ru>
	<200104060033.f360XfP03505@hak.lan.Awfulhak.org>
Sender: owner-freebsd-security@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

<<On Fri, 06 Apr 2001 01:33:41 +0100, Brian Somers <brian@Awfulhak.org> said:

> I believe the int is correct.

You are mistaken.  The purpose of the cast is to defeat the automatic
promotion from `char' to `int', which causes sign-extension if `char'
is signed.  Casting to `unsigned char' prevents this from happening.

-GAWollman



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message