From owner-svn-ports-all@FreeBSD.ORG Thu Oct 11 13:52:17 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 32A3FAC2; Thu, 11 Oct 2012 13:52:17 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 54D778FC16; Thu, 11 Oct 2012 13:52:16 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fw7so2797029vcb.13 for ; Thu, 11 Oct 2012 06:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=5XRd3U1vWasSEv09ze750WDNDxGOXwyNwYKgpJVeer8=; b=H2gN6sfbJrS9oPFFy7O9GhuukD78V2ciRjT7XadZzb3yibT2rVD/pYE4EXR2aZ41Zj pB036QUtvBN9cgDHscpJIyEGlbYKARz1L7FekjEIBUXTLTMVKjEGrzNrK2jHXXqWhB85 nw2qQlhYGixzVMJa/XGkiKA1EoHqFGZP2zvcW8qPGqYb1bm8AH3ubCACAounEQTZDXNl L/KmE0XlEXC40pVfFfvGHkKd52X8mkvlLoNUOZkC+0ZAr80aR6EyEyDqZ3LQhQ+OGDoh nnbVal6EI1V1ix731AvNjfbfAjxAKOPiGXUi9R6TPf/wXJtM01bDr2hQZCO++IUFoiij kf/g== Received: by 10.58.117.103 with SMTP id kd7mr543079veb.4.1349963535669; Thu, 11 Oct 2012 06:52:15 -0700 (PDT) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id x4sm577735vdh.13.2012.10.11.06.52.14 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 11 Oct 2012 06:52:15 -0700 (PDT) Sender: "Jason E. Hale" From: "Jason E. Hale" To: Ruslan Mahmatkhanov Subject: Re: svn commit: r305720 - head/mail/dbmail22 Date: Thu, 11 Oct 2012 09:52:13 -0400 Message-ID: <2655234.MtjR6MoGGX@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: <201210111324.q9BDOfdH029113@svn.freebsd.org> References: <201210111324.q9BDOfdH029113@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2012 13:52:17 -0000 On Thursday, October 11, 2012 13:24:41 Ruslan Mahmatkhanov wrote: > Author: rm > Date: Thu Oct 11 13:24:41 2012 > New Revision: 305720 > URL: http://svn.freebsd.org/changeset/ports/305720 > > Log: > - convert to optionsng > > PR: 172380 > Submitted by: Alan Hicks (maintainer) > Feature safe: yes > > Modified: > head/mail/dbmail22/Makefile > head/mail/dbmail22/pkg-descr > > Modified: head/mail/dbmail22/Makefile > ============================================================================ > == --- head/mail/dbmail22/Makefile Thu Oct 11 13:23:57 2012 (r305719) +++ > head/mail/dbmail22/Makefile Thu Oct 11 13:24:41 2012 (r305720) @@ -1,9 > > -OPTIONS= MYSQL "Build with MySQL support" on \ > - POSTGRESQL "Build with PostgreSQL support" off \ > - SQLITE "Build with SQLite support" off \ > - SIEVE "Build w. support for Sieve mail sorting language" off \ > - LDAP "Build with support for LDAP authentication" off > +OPTIONS_DEFINE= MYSQL PGSQL SQLITE SIEVE LDAP > +OPTIONS_DEFAULT=MYSQL > +SIEVE_DESC= Support for Sieve mail sorting language > > > -.if defined(WITHOUT_MYSQL) && !defined(WITH_POSTGRESQL) && > !defined(WITH_SQLITE) +.if empty(${PORT_OPTIONS:MMYSQL}) && > empty(${PORT_OPTIONS:MPGSQL}) && empty(${PORT_OPTIONS:MSQLITE}) > IGNORE="requires at least one database backend selected. Run 'make config'" > .endif > Wouldn't it be better to use OPTIONS_MULTI instead of the IGNORE message? OPTIONS_DEFINE= SIEVE LDAP OPTIONS_MULTI= DB OPTIONS_MULTI_DB= MYSQL PGSQL SQLITE ${} shouldn't be used within emtpy() either. E.g.: .if empty(${PORT_OPTIONS:MMYSQL}) -> .if empty(PORT_OPTIONS:MMYSQL) This port also has: .if !defined(NOPORTDOCS) Might as well convert to: .if ${PORT_OPTIONS:MDOCS} - Jason