From owner-cvs-ports@FreeBSD.ORG Mon Jan 18 07:19:36 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B10F1065670 for ; Mon, 18 Jan 2010 07:19:36 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id C75E08FC18 for ; Mon, 18 Jan 2010 07:19:35 +0000 (UTC) Received: (qmail 3860 invoked by uid 399); 18 Jan 2010 07:19:34 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 18 Jan 2010 07:19:34 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B540B8E.4050102@FreeBSD.org> Date: Sun, 17 Jan 2010 23:19:42 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.5) Gecko/20100114 Thunderbird/3.0 MIME-Version: 1.0 To: "Philip M. Gollucci" References: <201001180014.o0I0ELwM042687@repoman.freebsd.org> In-Reply-To: <201001180014.o0I0ELwM042687@repoman.freebsd.org> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, James E Risner , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/postgrey Makefile ports/mail/postgrey/files postgrey.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2010 07:19:36 -0000 Some of those things that are currently set as _flags look like they should probably be set as command_args instead. Anything that is required for the thing to run properly (such as the option to identify the pidfile, and the option to daemonize) would fall into this category. Also, you can (and probably should) simplify the script by setting pidfile right after load_rc_config like this: pidfile=${postgrey_pidfile:-/var/run/postgrey.pid} Then use --pidfile=${pidfile} in the command_args. hth, Doug On 01/17/10 16:14, Philip M. Gollucci wrote: > pgollucci 2010-01-18 00:14:21 UTC > > FreeBSD ports repository > > Modified files: > mail/postgrey Makefile > mail/postgrey/files postgrey.in > Log: > - Fix the rc.d script > > PR: ports/139046 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=139046 > Submitted by: James E Risner > Approved by: maintainer timeout > > Revision Changes Path > 1.22 +1 -0 ports/mail/postgrey/Makefile > 1.3 +3 -2 ports/mail/postgrey/files/postgrey.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postgrey/Makefile.diff?&r1=1.21&r2=1.22&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postgrey/files/postgrey.in.diff?&r1=1.2&r2=1.3&f=h > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso