From owner-freebsd-pkg@FreeBSD.ORG Thu Feb 19 09:38:21 2015 Return-Path: Delivered-To: freebsd-pkg@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0AA5ABD for ; Thu, 19 Feb 2015 09:38:21 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 977409BB for ; Thu, 19 Feb 2015 09:38:19 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id D8AB7BDC3E; Thu, 19 Feb 2015 10:38:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=mat.cc; h=date:from:to :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=plouf; bh=e0fDscgEior yr9dqbIdKgIXPvEc=; b=zBJujoIFe00PP3s74ecwawYEqElfW5vuNhAL4M7WjuF OhUvd2ogshabpp9iB/6qwQOmFkL9nWzg4IKFtiNgFPJCyY5SymcrD2j7NaDfsJZ4 Ayx9XZOBWfc5fRTDnQUL49viRR8SiV5Tf/ZUhW9YcBj/M8/TOKaUnt80PB54lCkE = Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id BA0B6BDC24; Thu, 19 Feb 2015 10:38:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id E3ADE26C04A4; Thu, 19 Feb 2015 10:37:59 +0100 (CET) Date: Thu, 19 Feb 2015 10:37:59 +0100 From: Mathieu Arnold To: Victor Sudakov , freebsd-pkg@freebsd.org Subject: Re: "poudriere distclean" complains about /etc/make.conf Message-ID: In-Reply-To: <20150219031446.GA32820@admin.sibptus.tomsk.ru> References: <20150217043049.GA68755@admin.sibptus.tomsk.ru> <20150218163739.GA24716@admin.sibptus.tomsk.ru> <20150219031446.GA32820@admin.sibptus.tomsk.ru> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: freebsd-pkg@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Binary package management and package tools discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 09:38:21 -0000 +--On 19 f=C3=A9vrier 2015 09:14:46 +0600 Victor Sudakov = wrote: | Mathieu Arnold wrote: |> +--On 18 f??vrier 2015 22:37:39 +0600 Victor Sudakov = |> wrote: |> | Mathieu Arnold wrote: |> |> |=20 |> |> | I have the following construct in /etc/make.conf but not in |> |> | /usr/local/etc/poudriere.d/make.conf: |> |> |=20 |> |> | .if ${.CURDIR:M*/mail/spamassassin} && ${HOST} =3D=3D = "relay.sibptus.ru" |> |> | = EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 |> |> | .endif |> |> |=20 |> |> | When I run "poudriere distclean", it complains about this |> |> | construct:=20 |> |> |=20 |> |> | WARNING (mail/spamassassin): "/etc/make.conf", line 15: |> |> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} && ${HOST} = =3D=3D |> |> | "relay.sibptus.ru") WARNING (mail/spamassassin): |> |> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING |> |> | (mail/spamassassin): make: fatal errors encountered -- cannot |> |> | continue |> |> |=20 |> |> | I have two questions. |> |> |=20 |> |> | 1. Why does it complain? The conditional seems legit. |> |>=20 |> |> It seems like it is, but it is not, it should be: |> |>=20 |> |> .if !empty(.CURDIR:M*/mail/spamassassin) && ${HOST} =3D=3D |> |> "relay.sibptus.ru" |> |> = EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 |> |> .endif |> |>=20 |> |> or |> |>=20 |> |> .if ${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST} =3D=3D |> |> "relay.sibptus.ru" |> |=20 |> | Sorry, Mathieu, your advice does not help: |> |=20 |> | [root@svn ~] poudriere distclean -y |> | [00:00:00] =3D=3D=3D=3D>> Gathering all expected distfiles for ports = tree |> | 'default' WARNING (mail/spamassassin): "/etc/make.conf", line 15: |> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} !=3D "" && = ${HOST} |> | =3D=3D "relay.sibptus.ru") WARNING (mail/spamassassin): |> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING |> | (mail/spamassassin): make: fatal errors encountered -- cannot continue = |>=20 |> Ah, yes, HOST is not defined, it's why it fails, you need to add: |>=20 |> HOST?=3D |=20 | Mathieu, what makes you think that HOST is not defined? It's defined | in the environment and should be available to make: |=20 | [sudakov@relay ~] make -V HOST | relay.sibptus.ru | [sudakov@relay ~] It's not defined in my environment, so I'd say it's specific to your setup, so, it's not defined when poudriere runs make, so it fails. --=20 Mathieu Arnold