From nobody Fri Apr 21 16:37:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q30Yj2BTJz46cHy; Fri, 21 Apr 2023 16:37:29 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q30Yh6b6Wz3HSB; Fri, 21 Apr 2023 16:37:28 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; none Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 409763C0199; Fri, 21 Apr 2023 16:37:22 +0000 (UTC) Date: Fri, 21 Apr 2023 16:37:22 +0000 From: Brooks Davis To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 559b94a12257 - main - syscall.master: Fix comments Message-ID: References: <202304202219.33KMJSY0042283@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <202304202219.33KMJSY0042283@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Q30Yh6b6Wz3HSB X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, Apr 20, 2023 at 10:19:28PM +0000, Warner Losh wrote: > The branch main has been updated by imp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D559b94a12257807115bf842649= 36f0de2ac3884e >=20 > commit 559b94a12257807115bf84264936f0de2ac3884e > Author: Warner Losh > AuthorDate: 2023-04-20 22:16:21 +0000 > Commit: Warner Losh > CommitDate: 2023-04-20 22:18:02 +0000 >=20 > syscall.master: Fix comments > =20 > Have more accruate comments. While #if, #else, etc are copied to the > header files, lines that don't start with # are not. And #include fi= les > are only output to sysinc (which winds up at the front of init_sysent= =2Ec > which seems a bit odd). This is all radically undocumented, and likely > has drifted somewhat from 4.4BSD and what other systems do (they've > drifted too, fwiw). We probably want to tighten what we do a fair bit with regard to '#' lines and perhaps make syscalls.master's format more explicit about what's being copied where. The historic behavior of blindly emitting lines beginning with '#' was there to support manual specification of things like padding of arguments to achieve 64-bit alignment on non-i386, 32-bit architectures. I think we should likely remove the support entirely post 14 branch (I'd kept it after the compat32 generation code because I was worried about breaking downstream consumers with custom syscalls, but by now they have had time to migrate.) -- Brooks