Date: Fri, 21 Apr 2023 16:37:22 +0000 From: Brooks Davis <brooks@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 559b94a12257 - main - syscall.master: Fix comments Message-ID: <ZEK7wu4xNEFoGG0%2B@spindle.one-eyed-alien.net> In-Reply-To: <202304202219.33KMJSY0042283@gitrepo.freebsd.org> References: <202304202219.33KMJSY0042283@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 20, 2023 at 10:19:28PM +0000, Warner Losh wrote: > The branch main has been updated by imp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D559b94a12257807115bf842649= 36f0de2ac3884e >=20 > commit 559b94a12257807115bf84264936f0de2ac3884e > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2023-04-20 22:16:21 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2023-04-20 22:18:02 +0000 >=20 > syscall.master: Fix comments > =20 > Have more accruate comments. While #if, #else, etc are copied to the > header files, lines that don't start with # are not. And #include fi= les > are only output to sysinc (which winds up at the front of init_sysent= =2Ec > which seems a bit odd). This is all radically undocumented, and likely > has drifted somewhat from 4.4BSD and what other systems do (they've > drifted too, fwiw). We probably want to tighten what we do a fair bit with regard to '#' lines and perhaps make syscalls.master's format more explicit about what's being copied where. The historic behavior of blindly emitting lines beginning with '#' was there to support manual specification of things like padding of arguments to achieve 64-bit alignment on non-i386, 32-bit architectures. I think we should likely remove the support entirely post 14 branch (I'd kept it after the compat32 generation code because I was worried about breaking downstream consumers with custom syscalls, but by now they have had time to migrate.) -- Brooks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZEK7wu4xNEFoGG0%2B>