From owner-cvs-src@FreeBSD.ORG Tue Nov 30 08:35:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC4C016A4CE; Tue, 30 Nov 2004 08:35:53 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6606343D49; Tue, 30 Nov 2004 08:35:53 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iAU8XTe1044492; Tue, 30 Nov 2004 01:33:29 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 30 Nov 2004 01:34:28 -0700 (MST) Message-Id: <20041130.013428.25281327.imp@bsdimp.com> To: marcel@xcllnt.net From: "M. Warner Losh" In-Reply-To: <41690958-42A5-11D9-A383-000D93C47836@xcllnt.net> References: <200411300256.iAU2urva052399@repoman.freebsd.org> <20041130073515.GA92857@ip.net.ua> <41690958-42A5-11D9-A383-000D93C47836@xcllnt.net> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: ru@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/usr.bin/gdb/kgdb Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2004 08:35:54 -0000 In message: <41690958-42A5-11D9-A383-000D93C47836@xcllnt.net> Marcel Moolenaar writes: : On Nov 29, 2004, at 11:35 PM, Ruslan Ermilov wrote: : : > On Tue, Nov 30, 2004 at 02:56:53AM +0000, Marcel Moolenaar wrote: : >> marcel 2004-11-30 02:56:53 UTC : >> : >> FreeBSD src repository : >> : >> Modified files: : >> gnu/usr.bin/gdb/kgdb Makefile : >> Log: : >> s/MACHINE_ARCH/TARGET_ARCH/. We use TARGET_ARCH to pick the MD files : >> for libgdb and should do so here as well. : >> : >> Revision Changes Path : >> 1.2 +1 -1 src/gnu/usr.bin/gdb/kgdb/Makefile : >> : > We use TARGET_ARCH only for cross-tools. Once upon a time, gdb : > was a cross-tool (as part of gnu/usr.bin/binutils). Not anymore. : > If it's not going to change then we should be using MACHINE_ARCH. : : I disagree. The fact that gdb is not a cross-tool in the buildworld : sense of the meaning is because we don't need gdb to cross-build world. : This does not mean that gdb cannot be a cross-tool from a developers : point of view. In fact, it's really handy to be able to debug a kernel : remotely when the debugger doesn't run on the same architecture as : the kernel. I for one do not want to have 2 machines per architecture : for the only reason that I want to debug a kernel remotely. So, I made : some changes to work towards that goal. I see no problems or harm, : especially since I'm not misusing TARGET_ARCH. The ability to build a : cross-debugger is simply not utilized as part of a buildworld. But MACHINE_ARCH is set correctly during the build of gdb when you've set TARGET_ARCH to build the rest of the world you need to build gdb with. Or am I missing something? Warner