Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 May 2016 00:38:17 +0000 (UTC)
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r300895 - head/sys/dev/cxgbe/tom
Message-ID:  <201605280038.u4S0cHTS032062@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: np
Date: Sat May 28 00:38:17 2016
New Revision: 300895
URL: https://svnweb.freebsd.org/changeset/base/300895

Log:
  cxgbe/t4_tom: Exempt RDMA connections from a TCP sanity test for now, to
  avoid panicking debug kernels.
  
  t4_tom does not keep track of a connection once it switches to ULP mode
  iWARP.  If the connection falls out of ULP mode the driver/hardware seq#
  etc. are out of sync.  A better fix would be to figure out what the
  current seq# are, update the driver's state, and perform all sanity
  checks as usual.

Modified:
  head/sys/dev/cxgbe/tom/t4_cpl_io.c

Modified: head/sys/dev/cxgbe/tom/t4_cpl_io.c
==============================================================================
--- head/sys/dev/cxgbe/tom/t4_cpl_io.c	Sat May 28 00:22:39 2016	(r300894)
+++ head/sys/dev/cxgbe/tom/t4_cpl_io.c	Sat May 28 00:38:17 2016	(r300895)
@@ -1417,7 +1417,11 @@ do_rx_data(struct sge_iq *iq, const stru
 		ddp_placed = be32toh(cpl->seq) - tp->rcv_nxt;
 
 	tp->rcv_nxt += len;
-	KASSERT(tp->rcv_wnd >= len, ("%s: negative window size", __func__));
+	if (tp->rcv_wnd < len) {
+		KASSERT(toep->ulp_mode != ULP_MODE_RDMA,
+				("%s: negative window size", __func__));
+	}
+
 	tp->rcv_wnd -= len;
 	tp->t_rcvtime = ticks;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605280038.u4S0cHTS032062>