From owner-p4-projects@FreeBSD.ORG Mon Aug 20 03:51:11 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F098B16A420; Mon, 20 Aug 2007 03:51:10 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C73D816A417 for ; Mon, 20 Aug 2007 03:51:10 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B5E4F13C45E for ; Mon, 20 Aug 2007 03:51:10 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7K3pAlD043879 for ; Mon, 20 Aug 2007 03:51:10 GMT (envelope-from cnst@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7K3pArk043866 for perforce@freebsd.org; Mon, 20 Aug 2007 03:51:10 GMT (envelope-from cnst@FreeBSD.org) Date: Mon, 20 Aug 2007 03:51:10 GMT Message-Id: <200708200351.l7K3pArk043866@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cnst@FreeBSD.org using -f From: "Constantine A. Murenin" To: Perforce Change Reviews Cc: Subject: PERFORCE change 125385 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 03:51:11 -0000 http://perforce.freebsd.org/chv.cgi?CH=125385 Change 125385 by cnst@dale on 2007/08/20 03:50:39 add a caveats section documenting sensor_task differences in OpenBSD 4.2, sensor_task was converted to use use OpenBSD's workq_add_task(9), which is not available on FreeBSD. In cnst-sensors, I have so far ported the older version of sensor_task as all of the necessary functions that it uses are here on FreeBSD. It is questionable whether sensor_task in soc2007/cnst-sensors should be compatible with 4.2, because it will involve additional code that is, at this point, noone except for me is testing. So for now, I think it is a much wiser choice to stick with sensor_task that is compatible with 4.1, and then when I'll have some testers, write an entirely new sensor_task if that will be deemed necessary. P.S. Converting the drivers from old sensor_task to new sensor_task (and back) is as easy as 123. :) In any case, any help or hints with sensor_task is appreciated. The current implementation for FreeBSD is long as available in the p4 repository, in soc2007/cnst-sensors/sys.kern/kern_sensors.c. Affected files ... .. //depot/projects/soc2007/cnst-sensors/share.man.man9/sensor_attach.9#2 edit Differences ... ==== //depot/projects/soc2007/cnst-sensors/share.man.man9/sensor_attach.9#2 (text+ko) ==== @@ -1,4 +1,4 @@ -.\" $P4: //depot/projects/soc2007/cnst-sensors/share.man.man9/sensor_attach.9#1 $ +.\" $P4: //depot/projects/soc2007/cnst-sensors/share.man.man9/sensor_attach.9#2 $ .\" $FreeBSD$ .\" $OpenBSD: sensor_attach.9,v 1.4 2007/03/22 16:55:31 deraadt Exp $ .\" @@ -126,3 +126,22 @@ by .An Constantine A. Murenin as a Google Summer of Code 2007 project. +.Sh CAVEATS +The +.Fn sensor_task_register +and +.Fn sensor_task_unregister +functions that are included in +.Ox 4.2 +and later +are not compatible with +.Fx . +.Fx +includes an implementation that is similar and compatible +with an earlier version of +these +.Va sensor_task +functions that was available from +.Ox 3.9 +until +.Ox 4.1 .