From owner-freebsd-current Wed Sep 11 13:51:09 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA29387 for current-outgoing; Wed, 11 Sep 1996 13:51:09 -0700 (PDT) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA29378 for ; Wed, 11 Sep 1996 13:51:03 -0700 (PDT) Received: (from root@localhost) by dyson.iquest.net (8.7.5/8.6.9) id PAA00852; Wed, 11 Sep 1996 15:50:46 -0500 (EST) From: John Dyson Message-Id: <199609112050.PAA00852@dyson.iquest.net> Subject: Re: patch for Cyrix/Ti 486SLC/DLC CPU bug To: bde@zeta.org.au (Bruce Evans) Date: Wed, 11 Sep 1996 15:50:45 -0500 (EST) Cc: bde@zeta.org.au, dyson@dyson.iquest.net, current@FreeBSD.org, dg@Root.COM, kato@eclogite.eps.nagoya-u.ac.jp In-Reply-To: <199609112023.GAA10051@godzilla.zeta.org.au> from "Bruce Evans" at Sep 12, 96 06:23:04 am Reply-To: dyson@FreeBSD.org X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > > >> pmap_update_{1,2}pg(). The magic .byte's are a bad way of writing > >> `invlpg' (even gas understands this). > >> > >I don't know the syntax -- change it, and I'll propagate it!!! > > Intel gives the syntax `invlpg m' where m is a memory address. This > maps nicely to gcc inline asm (I think the contstraint is "m"). > > I would put this in cpufunc.h since it is a single instruction and > might be useful elsewhere. Is it reasonable for device drivers to > invalidate pages directly? > It is unreasonable (IMO) but unavoidable if the system doesn't provide a needed service. It is difficult to imagine a machine independent reason to do a pmap_update (but I guess that it might be possible.) So, to kind-of answer your comment -- I will put it in cpufunc, but the only module that should normally need it would be pmap.c??? John