From owner-freebsd-net@FreeBSD.ORG Wed Oct 12 20:42:24 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 107AA1065674 for ; Wed, 12 Oct 2011 20:42:24 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 7C3198FC1B for ; Wed, 12 Oct 2011 20:42:23 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id p9CKgMDm042017; Wed, 12 Oct 2011 22:42:22 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id p9CKgMk5042016; Wed, 12 Oct 2011 22:42:22 +0200 (CEST) (envelope-from marius) Date: Wed, 12 Oct 2011 22:42:22 +0200 From: Marius Strobl To: YongHyeon PYUN Message-ID: <20111012204222.GC39118@alchemy.franken.de> References: <20111009165838.GA19886@alchemy.franken.de> <20111010192238.GC1781@michelle.cdnetworks.com> <20111011212318.GC81376@alchemy.franken.de> <20111011225531.GD5661@michelle.cdnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111011225531.GD5661@michelle.cdnetworks.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@freebsd.org, dave jones Subject: Re: Question about GPIO bitbang MII X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2011 20:42:24 -0000 On Tue, Oct 11, 2011 at 03:55:31PM -0700, YongHyeon PYUN wrote: > On Tue, Oct 11, 2011 at 11:23:18PM +0200, Marius Strobl wrote: > > On Mon, Oct 10, 2011 at 12:22:38PM -0700, YongHyeon PYUN wrote: > > > On Sun, Oct 09, 2011 at 06:58:38PM +0200, Marius Strobl wrote: > > > > On Fri, Oct 07, 2011 at 10:34:58AM +0800, dave jones wrote: > > > > > Hi, > > > > > > > > > > Does FreeBSD have gpio bitbang api for MII? If not, any driver in tree using > > > > > gpio-bitbang mii that I can refer to? Thanks. > > > > > It seems like OpenBSD, NetBSD and Linux have added support to gpio bitbang mii, > > > > > and it's useful for porting embedded devices. > > > > > > > > > > > > > If what you are referring to is their mii_bitbang.[c,h] then I've a patch > > > > which (im)ports these and converts drivers to take advantage of it here: > > > > http://people.freebsd.org/~marius/mii_bitbang.diff > > > > > > Patch looks good to me. > > > What about other drivers(rl(4), bm(4), lge(4), tl(4), nge(4), wb(4) > > > and xe(4))? > > > > > > > Meanwhile I've also converted bm(4), just re-fetch the patch. Generally > > I've started with the drivers were the corresponding NetBSD one also > > uses the common MII bitbang'ing code. As for nge(4), tl(4), wb(4) I'm > > aware that these should also be convertible to the common code, I just > > didn't get around to it so far. As for lge(4) that driver has some > > remnants of MII bitbang'ing but doesn't actually use it AFAICT. I've > > Ah, I just blindly grepped the string, sorry. > > > previously missed rl(4) as I was only grepping beneath sys/dev and I > > currently can't explain why I missed xe(4), so thanks for mentioning > > these. > > In my experience MII bitbang'ing is very fragile though and subtle > > changes may break it so I don't want to commit these without testing > > or in the case of smc(4) where at least the corresponding NetBSD > > driver already uses the common code. Unfortunately, I only have > > hardware for dc(4), stge(4), xl(4) and somewhere also for rl(4) and > > tl(4) and I guess I can nwhitehorn@ regarding testing bm(4). Do you > > happen to have hardware to test the remaining drivers, i.e. nge(4), > > sis(4), ste(4), wb(4) and xe(4)? > > > > I have access to sis(4) and ste(4). I also have a nge(4) but I'm > not able to access to the hardware, at least in US. > It would be great if you could test sis(4) and ste(4). Marius