From owner-freebsd-current Fri Oct 6 6:41:41 2000 Delivered-To: freebsd-current@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 8B6D437B66D for ; Fri, 6 Oct 2000 06:41:37 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.9.3/8.9.3) with SMTP id JAA64892; Fri, 6 Oct 2000 09:41:29 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 6 Oct 2000 09:41:29 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Wesley Morgan Cc: current@freebsd.org Subject: Re: panic in ufs_extattr_uepm_destroy() In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 5 Oct 2000, Wesley Morgan wrote: > I'm getting a panic in ufs_extattr_uepm_destroy() because in ffs_vfsops.c > it is being called (line 788) with ump NULL: > > ufs_extattr_uepm_destroy(&ump->um_extattr); > > Of course disabling FFS_EXTATTR gets rid of this:) Hmm. I added these changes without adequate testing so as to fix a problem with Jason's addition of a lockdestroy, which also rapidly resulted in a mess :-). I'm away from my dev box right now, as I'm on travel, so haven't tested the following, but it should work. Let me know, and I'll commit it ASAP. Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services Index: ffs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v retrieving revision 1.129 diff -u -r1.129 ffs_vfsops.c --- ffs_vfsops.c 2000/10/04 04:44:51 1.129 +++ ffs_vfsops.c 2000/10/06 13:40:57 @@ -772,7 +772,7 @@ int mntflags; struct proc *p; { - register struct ufsmount *ump; + register struct ufsmount *ump = VFSTOUFS(mp); register struct fs *fs; int error, flags; @@ -794,7 +794,6 @@ if ((error = ffs_flushfiles(mp, flags, p)) != 0) return (error); } - ump = VFSTOUFS(mp); fs = ump->um_fs; if (fs->fs_ronly == 0) { fs->fs_clean = fs->fs_flags & FS_UNCLEAN ? 0 : 1; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message